Merge lp://staging/~charlesk/indicator-power/lp-1215520 into lp://staging/indicator-power/13.10
| Status: | Merged |
|---|---|
| Approved by: | Ted Gould |
| Approved revision: | 203 |
| Merged at revision: | 203 |
| Proposed branch: | lp://staging/~charlesk/indicator-power/lp-1215520 |
| Merge into: | lp://staging/indicator-power/13.10 |
| Diff against target: |
81 lines (+13/-20) 2 files modified
src/device.c (+1/-8) tests/test-device.cc (+12/-12) |
| To merge this branch: | bzr merge lp://staging/~charlesk/indicator-power/lp-1215520 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Revert bug #824629 code -- use the correct charge % when deciding what icon to use.
Description of the change
As described in bug #824629, on the Desktop it's sometimes difficult to tell whether a battery is charging or discharging because the lightning bolt is a little hard to see when laid against the background of a charged battery. The (IMO ugly) workaround at the time was to always use a nearly-empty battery icon so that the pixels beneath the lightning bolt were blank, making it easier to see.
The drawback of this approach is that the icon no longer gives useful information about the battery charge. This occurs on both desktop and tablet, but is more visible on the tablet because it has clearer icons.
This MP reverts the 824629 code to use the correct charge % when deciding what icon to use.
| PS Jenkins bot (ps-jenkins) | # |
| PS Jenkins bot (ps-jenkins) wrote | # |
Seems like a gain overall. Hopefully the icons will get fixed in the icon theme.