Indicator Date and Time

Merge lp://staging/~charlesk/indicator-datetime/lp-1465806-inject-missing-triggers-to-clock-app-alarms into lp://staging/indicator-datetime/15.04

  1. lp-1465806-inject-missing-triggers-to-clock-app-alarms
  2. Merge into trunk.15.04
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 417
Merged at revision: 416
Proposed branch: lp://staging/~charlesk/indicator-datetime/lp-1465806-inject-missing-triggers-to-clock-app-alarms
Merge into: lp://staging/indicator-datetime/15.04
Diff against target: 374 lines (+321/-2)
5 files modified
src/engine-eds.cpp (+135/-2)
tests/CMakeLists.txt (+1/-0)
tests/print-to.h (+24/-0)
tests/test-eds-ics-missing-trigger.cpp (+116/-0)
tests/test-eds-ics-missing-trigger.ics (+45/-0)
To merge this branch: bzr merge lp://staging/~charlesk/indicator-datetime/lp-1465806-inject-missing-triggers-to-clock-app-alarms
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+262297@code.staging.launchpad.net

Commit message

Fix invalid valarms in older clock-app alarms.

Description of the change

When we connect to an EClient, look for clock-app alarms whose valarms don't have triggers. If any are found, inject one.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:417
http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-ci/3/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-amd64-ci/3
    SUCCESS: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/indicator-datetime-15.04-vivid-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/indicator-datetime-15.04-ci/3/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

+1

review: Approve
Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

Does this run every time? Any concern about the overhead such that we would want to ensure it only runs once to fix them and never again? Or is there a way to avoid getting alarms that already have triggers?

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches