lp://staging/~charlesk/indicator-datetime/lp-1419001-honor-ical-valarms

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/indicator-datetime/15.04 at revision 408

PS Jenkins bot (community): Approve (continuous-integration) on 2015-04-06

Ted Gould (community): Approve on 2015-04-06

Diff: 1791 lines (+834/-269)

33 files modified

debian/control (+11/-8)
include/datetime/alarm-queue-simple.h (+6/-12)
include/datetime/alarm-queue.h (+1/-1)
include/datetime/appointment.h (+19/-4)
include/datetime/clock-mock.h (+1/-1)
include/datetime/clock.h (+1/-1)
include/datetime/date-time.h (+5/-1)
include/datetime/planner-snooze.h (+1/-2)
include/datetime/snap.h (+2/-1)
include/datetime/wakeup-timer-mainloop.h (+2/-2)
include/datetime/wakeup-timer-powerd.h (+2/-2)
include/datetime/wakeup-timer.h (+1/-1)
src/actions-live.cpp (+13/-6)
src/actions.cpp (+2/-2)
src/alarm-queue-simple.cpp (+140/-109)
src/appointment.cpp (+9/-3)
src/date-time.cpp (+31/-9)
src/engine-eds.cpp (+153/-54)
src/main.cpp (+7/-5)
src/planner-snooze.cpp (+10/-6)
src/snap.cpp (+9/-7)
tests/CMakeLists.txt (+33/-4)
tests/manual-test-snap.cpp (+5/-5)
tests/print-to.h (+45/-0)
tests/run-eds-test.sh (+57/-0)
tests/test-alarm-queue.cpp (+10/-7)
tests/test-eds-valarms-config-files/.config/evolution/sources/system-proxy.source (+21/-0)
tests/test-eds-valarms-config-files/.local/share/evolution/calendar/system/calendar.ics (+47/-0)
tests/test-eds-valarms.cpp (+101/-0)
tests/test-live-actions.cpp (+0/-6)
tests/test-snap.cpp (+10/-10)
tests/timezone-mock.h (+1/-0)
tests/wakeup-timer-mock.h (+78/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1419001: Reminders trigger at the time of the event and not before by default

High

Fix Released

Link a bug report

Related blueprints

430. By Charles Kerr on 2015-04-06

in tests/run-eds-test.sh, only delete the tmpdir if the test passed.

429. By Charles Kerr on 2015-04-06

in the EDS engine, give a better explanation in the comments how we handle alarms with no triggers, and why

428. By Charles Kerr on 2015-04-06

in EngineEds, make the ECalComponentAlarmAction 'omit' array a constexpr.

427. By Charles Kerr on 2015-04-06

in SimpleAlarmQueue, add a new method 'bool already_triggered() const' to reduce code overlapl between find_next_alarm() and appointment_get_current_alarm()

426. By Charles Kerr on 2015-04-06

in SimpleAlarmQueue, make the signature for find_next_alarm() and appointment_get_current_alarm() suck less.

425. By Charles Kerr on 2015-04-06

in SimpleAlarmQueue, reduce a lambda capture to only the fields it needs

424. By Charles Kerr on 2015-04-06

in Actions, sync DateTime API use by calling DateTime::Local(time_t) instead of DateTime::DateTime(time_t)

423. By Charles Kerr on 2015-04-06

in new EDS code, use timezones consistently

422. By Charles Kerr on 2015-04-06

in new EDS tests, use timezones consistently

421. By Charles Kerr on 2015-04-06

in DateTime class, make it harder to accidentally mix local and nonlocal timezones by replacing DateTime::DateTime(time_t) with two methods, DateTime::Local(time_t) and DateTime(GTimeZone*, time_t)