Merge lp://staging/~charlesk/indicator-datetime/fix-943747 into lp://staging/indicator-datetime/0.4
Proposed by
Charles Kerr
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Ted Gould | ||||
| Approved revision: | 157 | ||||
| Merge reported by: | Charles Kerr | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~charlesk/indicator-datetime/fix-943747 | ||||
| Merge into: | lp://staging/indicator-datetime/0.4 | ||||
| Diff against target: |
27 lines (+3/-0) 1 file modified
src/datetime-prefs.c (+3/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~charlesk/indicator-datetime/fix-943747 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The Coverity warning about sscanf() seems to be that humans need to verify that there won't be a buffer overrun from scanning into a char array. I've done so and added comments to Coverity to silence the warning.
I'm not 100% sure about the use of /* coverity[
To post a comment you must log in.
Revision history for this message
| Charles Kerr (charlesk) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
On Sun, 2012-03-04 at 01:00 +0000, charles wrote:
> I'm not 100% sure about the use of /* coverity[
> it appears this is how other projects, such as libinktomi++, do it.
Me neither, let's try it.
review approve
status approved