Ubuntu
ubuntu-advantage-tools package

Code review comment for ~chad.smith/ubuntu/+source/ubuntu-advantage-tools:pkg-upload-24.4

  1. Git
  2. lp:~chad.smith/ubuntu/+source/ubuntu-advantage-tools
  3. pkg-upload-24.4
  4. Merge into ubuntu/devel
Revision history for this message
Bryce Harrington (bryce) wrote :

One other minor niggle, the indentation on the changelog entry is one space too many:

   * New bug-fix-only release 24.4:
      - uaclient.version bump to 24.4
      - fips: honor additionalPackage directive from contract for bionic
        (GH #1173)

I dedented locally for the upload but you may want to update your git tree too.

Otherwise, thanks for confirming my assumptions on the config data, so everything looks good for upload.

review: Approve
Reply

« Back to merge proposal