Merge lp://staging/~chad.smith/lp2kanban/branch-to-card into lp://staging/lp2kanban
Status: | Merged |
---|---|
Merged at revision: | 120 |
Proposed branch: | lp://staging/~chad.smith/lp2kanban/branch-to-card |
Merge into: | lp://staging/lp2kanban |
Diff against target: |
554 lines (+213/-46) 4 files modified
src/lp2kanban/bugs2cards.py (+70/-13) src/lp2kanban/kanban.py (+79/-16) src/lp2kanban/tests/common.py (+5/-2) src/lp2kanban/tests/test_bugs2cards.py (+59/-15) |
To merge this branch: | bzr merge lp://staging/~chad.smith/lp2kanban/branch-to-card |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Данило Шеган (community) | Approve | ||
Landscape | Pending | ||
Review via email:
|
Description of the change
Add initial support for branch cards and taskboards. This branch only handles syncing and moving branch "MP/blue" cards on the Landscape 2016 board.
Support was added for branch cards inside bugs2card because a lot of the logic is common and can hopefully be consolidated in a subsequent branch.
There will be a followup branch with added logic in bugs2cards to call moveToTaskBoard for feature cards that are manually dragged to the "$Group::Landed" lane.
src/lp2kanban/
- Define initial LeankitTaskBoard class
- Add optional CurrentTaskBoardId property to LeankitCard
- Add LeankitCard.
- Since Taskboard API calls live on a different route, rework API routes defined on the LeankitConnector class
src/lp2kanban/
- _get_mp_info to handle non-bug branch records when parsing linked MPs
- should_sync_card to return true if external_system_url is a branch
- get_card_status returns proper status for cards that have external_
- add a loop to sync_board function which processes all "branch cards" through board.getCardsW
config/sync.ini:
- comment out [Landscape Cisco] board definition (as that should live in this board now
To test:
buildout
./bin/test
# to test against the new landscape 2016 board
./create_creds.py (this will create your creds to modify the shared 2016 board)
Select "Change anything" button in your browser to allow updating cards
make config
./bin/py src/lp2kanban/
# Tweak branches or drag cards at https:/
What's lacking:
unit tests to cover bugs2card sync_board (coming in a followup branch)
Please merge latest lp:~landscape/lp2kanban/landscape-deploy and drop configs altogether (merge them into lp:~landscape/landscape/lp2kanban-configs instead).
Looks good, only minor comments inline.