Landscape Client

Merge lp://staging/~chad.smith/landscape-client/mocker-to-mock-processorinfo into lp://staging/~landscape/landscape-client/trunk

  1. mocker-to-mock-processorinfo
  2. Merge into trunk
Proposed by Chad Smith
Status: Merged
Approved by: Chad Smith
Approved revision: 853
Merged at revision: 856
Proposed branch: lp://staging/~chad.smith/landscape-client/mocker-to-mock-processorinfo
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 34 lines (+6/-5)
1 file modified
landscape/monitor/tests/test_processorinfo.py (+6/-5)
To merge this branch: bzr merge lp://staging/~chad.smith/landscape-client/mocker-to-mock-processorinfo
Reviewer Review Type Date Requested Status
🤖 Landscape Builder test results Approve
Bogdana Vereha (community) Approve
Alberto Donato Approve
Review via email: mp+297529@code.staging.launchpad.net

Commit message

Move from mocker to mock for processorinfo unit tests.

Description of the change

Move from mocker to mock for processorinfo unit tests.

To post a comment you must log in.
Revision history for this message
Alberto Donato (ack) wrote :

+1

review: Approve
Revision history for this message
Bogdana Vereha (bogdana) wrote :

This is ok, but context managers are cooler.

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make check
Result: Success
Revno: 853
Branch: lp:~chad.smith/landscape-client/mocker-to-mock-processorinfo
Jenkins: https://ci.lscape.net/job/latch-test/5048/

review: Approve (test results)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: