Merge lp://staging/~cgregan/checkbox/usb-performance into lp://staging/checkbox

Added usb/usb3 performance

The commands are both the same, and contain the parameters for USB 3.0 (particularly the -m value will not allow this to work with a USB 2.0 device).

So the command for USB 2.0 needs updating, I'd remove the -m parameter and value, and set a lower threshold (-p value). Theoretical max for USB 2.0 is 60 MB/s (vs. 625 MB/s for USB 3.0).

Since we're generically asking for "usb storage device" and not "hard disk", the actual transfer speed will be much lower, I suggest doing some tests with usb sticks and deciding on a threshold. For reference, USB 1.0 transferred at 1.5 MB/s, so we definitely want something higher than that for USB 2.0.

Are we sure this is the approach we want to take for USB? For mediacards it makes sense because of the variables in testing those, but for USB it might be feasible to automate it. If we do want to take this approach, no problem - I can update my merge requests to not touch the performance tests.

Apart from that, echoing mostly what Daniel said - the usb/usb-performance job needs to have its -m value reduced/removed - currently it will only work with usb 3.0 devices. Additionally, both jobs need estimated_duration and if we're taking the manual route then we can remove the -p option altogether since we don't want to test what the transfer speed was (just display it)

Didn't we do this in another branch already? If so, let's reject this MR. Let me know.

yes...lemme add yout name to the branch I created yesterday

On Thu, Mar 13, 2014 at 2:12 PM, Daniel Manrique <
<email address hidden>> wrote:

> Review: Needs Information
>
> Didn't we do this in another branch already? If so, let's reject this MR.
> Let me know.
> --
> https://code.launchpad.net/~cgregan/checkbox/usb-performance/+merge/208026
> You are the owner of lp:~cgregan/checkbox/usb-performance.
>

--
Chris Gregan
Project Quality Manager
Professional and Engineering Services
Canonical USA Inc.
<email address hidden>
cgregan[irc.freenode.net]
W-781-761-9448

----
1024/8806032D
E70F 7391 6C78 9B9E 6461 1CC7 B168 E1E7 8806 032D

Not needed anymore, so let's reject to remove from the list of pending reviews.