OpenERP Community Backports (Addons)

Merge lp://staging/~cedric-lebrouster/ocb-addons/ocb-6.1-bug-740361-aml-novalidate into lp://staging/ocb-addons/6.1

  1. ocb-6.1-bug-740361-aml-novalidate
  2. Merge into 6.1
Proposed by Cedric Le Brouster(OpenFire)
Status: Needs review
Proposed branch: lp://staging/~cedric-lebrouster/ocb-addons/ocb-6.1-bug-740361-aml-novalidate
Merge into: lp://staging/ocb-addons/6.1
Diff against target: 21 lines (+2/-2)
1 file modified
account/account_move_line.py (+2/-2)
To merge this branch: bzr merge lp://staging/~cedric-lebrouster/ocb-addons/ocb-6.1-bug-740361-aml-novalidate
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+251279@code.staging.launchpad.net

Description of the change

Fix for the bug 740361.
Checks for 'novalidate' definition in account.move.line context in create() and write() method, to prevent useless calls to account.move validate() method for each line (huge time loss)

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Seems reasonably.

review: Approve (code review)
Reply
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Thanks! I can see that 'novalidate' is checked in the same places in upstream 8.0.

review: Approve
Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Should we merge it already or wait any other review?

Reply

Unmerged revisions

6849. By Cedric Le Brouster(OpenFire)

[FIX] Prevents unwanted calls to account.move validate() method, which makes moves create/write very slow when they have many lines.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches