Capomastro

Merge lp://staging/~ce-infrastructure/capomastro/deploy-jenkins-merge-1387601 into lp://staging/~ubuntuone-hackers/capomastro/deploy

  1. deploy-jenkins-merge-1387601
  2. Merge into deploy
Proposed by Caio Begotti
Status: Merged
Merge reported by: Caio Begotti
Merged at revision: not available
Proposed branch: lp://staging/~ce-infrastructure/capomastro/deploy-jenkins-merge-1387601
Merge into: lp://staging/~ubuntuone-hackers/capomastro/deploy
Diff against target: 92 lines (+35/-10)
4 files modified
config/jenkins.yaml (+1/-1)
config/jenkins/hooks/install.d/bygmester (+20/-0)
deploy.sh (+6/-6)
init.sh (+8/-3)
To merge this branch: bzr merge lp://staging/~ce-infrastructure/capomastro/deploy-jenkins-merge-1387601
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+242785@code.staging.launchpad.net

Description of the change

Simplified Jenkins API relation so the upstream maintainers of its charm can possibly merge our custom charm without fuss.

To post a comment you must log in.
lp://staging/~ce-infrastructure/capomastro/deploy-jenkins-merge-1387601 updated
45. By Caio Begotti

typo coming from the old branch url, my bad

Revision history for this message
Daniel Manrique (roadmr) wrote :

Looks OK, I made a couple of comments, one is minor but the one about the PPA string may need some attention.

review: Needs Information
Revision history for this message
Caio Begotti (caio1982) :
Revision history for this message
Daniel Manrique (roadmr) wrote :

A couple of replies. I'd be OK to merge this, given that the idea is to seek input on those contention points.

Revision history for this message
Caio Begotti (caio1982) wrote :

I think for the moment this is what we have but I'll think of a way to polish the init.sh script later although I don't really believe there will be a clean solution for the private PPA problem, I just don't want to make things need a manual setup.

Revision history for this message
Daniel Manrique (roadmr) wrote :

OK, I'll say "approve" to get this to the next stage which is getting feedback.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches