Merge lp://staging/~ce-infrastructure/capomastro/capomastro-private-ppa-1387809 into lp://staging/~ubuntuone-hackers/capomastro/charm
Proposed by
Caio Begotti
| Status: | Merged |
|---|---|
| Merged at revision: | 54 |
| Proposed branch: | lp://staging/~ce-infrastructure/capomastro/capomastro-private-ppa-1387809 |
| Merge into: | lp://staging/~ubuntuone-hackers/capomastro/charm |
| Diff against target: |
39 lines (+6/-4) 3 files modified
config.yaml (+4/-1) hooks/install (+1/-3) inc/common (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~ce-infrastructure/capomastro/capomastro-private-ppa-1387809 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sheila Miguez (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
It is really annoying that apt-add-repository won't accept private PPAs so that was needed otherwise I would have to keep changing the install hooks of both Capomastro's and our forked Jenkins' charms. At least with this we can keep the private repository line with auth stuff in it separated in a config.yaml used for deployment only. This only affects Capomastro as the Jenkins changes were pushed to my forked (+junk) Jenkins charm already.
To post a comment you must log in.
Revision history for this message
| Caio Begotti (caio1982) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Btw this is the original bug that this will fix, eventually: https:/