Merge lp://staging/~ce-infrastructure/capomastro/capomastro-jenkins-notifications-1385218 into lp://staging/~ubuntuone-hackers/capomastro/charm
Proposed by
Caio Begotti
| Status: | Merged |
|---|---|
| Merged at revision: | 53 |
| Proposed branch: | lp://staging/~ce-infrastructure/capomastro/capomastro-jenkins-notifications-1385218 |
| Merge into: | lp://staging/~ubuntuone-hackers/capomastro/charm |
| Diff against target: |
9 lines (+1/-1) 1 file modified
templates/capomastro_local_settings.tmpl (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~ce-infrastructure/capomastro/capomastro-jenkins-notifications-1385218 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sheila Miguez (community) | Approve | ||
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Pretty small merge request because I finally had this problem again and for some weird Juju bug (and I believe it's a problem with Juju timings, as I have seen this before) the notification host is not properly populated with the instance address, but it is normally populated if it's wrapped by the http:// protocol string and an ending slash. Odd. Dunno why, sorry, but it worked and it seems more sanitized anyway.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
If it's a timing issue, this will happen again, and we can figure out a solution then. Until such a time, this looks good/harmless. +1 from me, thanks!