Merge lp://staging/~ccanepacc/dateutil/fix-py2X-tzwin-import into lp://staging/dateutil

Proposed by ccanepa
Status: Needs review
Proposed branch: lp://staging/~ccanepacc/dateutil/fix-py2X-tzwin-import
Merge into: lp://staging/dateutil
Diff against target: 15 lines (+4/-1)
1 file modified
dateutil/tzwin.py (+4/-1)
To merge this branch: bzr merge lp://staging/~ccanepacc/dateutil/fix-py2X-tzwin-import
Reviewer Review Type Date Requested Status
jarondl (community) Disapprove
Dateutil Maintainers Pending
Review via email: mp+224594@code.staging.launchpad.net

Description of the change

Changes the 'import winreg' that only works in py2.X to the try / except that loads the appropriate module in any python and binds to the name winreg

No test added, the one added in lp:~ccanepacc/dateutil/fix-isdst-in-tzwin will also detect the problem

Tested in win xp , py 2.7, 3.2, 3.3

To post a comment you must log in.
Revision history for this message
ccanepa (ccanepacc) wrote :

Sorry, forgot to add the bug it address is
https://bugs.launchpad.net/dateutil/+bug/1143880

Revision history for this message
jarondl (jarondl) wrote :

This was solved with six on 2.3

review: Disapprove

Unmerged revisions

136. By ccanepa

fix py2X tzwin import

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: