Merge lp://staging/~cbjchen/charms/trusty/heat/next-ha into lp://staging/~openstack-charmers-archive/charms/trusty/heat/next

Proposed by Liang Chen
Status: Merged
Merged at revision: 71
Proposed branch: lp://staging/~cbjchen/charms/trusty/heat/next-ha
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/heat/next
Diff against target: 397 lines (+228/-15)
6 files modified
config.yaml (+34/-0)
hooks/heat_relations.py (+128/-4)
hooks/heat_utils.py (+3/-2)
metadata.yaml (+6/-0)
tests/basic_deployment.py (+6/-6)
unit_tests/test_heat_relations.py (+51/-3)
To merge this branch: bzr merge lp://staging/~cbjchen/charms/trusty/heat/next-ha
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+286641@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-02-19.

Description of the change

Provide Heat charm HA support

To post a comment you must log in.
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #15610 heat-next for cbjchen mp280946
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/14086903/
Build: http://10.245.162.77:8080/job/charm_lint_check/15610/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #14567 heat-next for cbjchen mp280946
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/14086905/
Build: http://10.245.162.77:8080/job/charm_unit_test/14567/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8330 heat-next for cbjchen mp280946
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14086964/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8330/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #16509 heat-next for cbjchen mp280946
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16509/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #15415 heat-next for cbjchen mp280946
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: pastebin not avail., cmd error
Build: http://10.245.162.77:8080/job/charm_unit_test/15415/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8495 heat-next for cbjchen mp280946
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14399097/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8495/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #15481 heat-next for cbjchen mp280946
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 1
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/14407592/
Build: http://10.245.162.77:8080/job/charm_unit_test/15481/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #16585 heat-next for cbjchen mp280946
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16585/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8502 heat-next for cbjchen mp280946
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14407692/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8502/

Revision history for this message
Liam Young (gnuoy) wrote : Posted in a previous version of this proposal

amulet tests and unit tests need some tweaks. Otherwise looks good to me, thanks for mp!

review: Needs Fixing
Revision history for this message
Liang Chen (cbjchen) wrote : Posted in a previous version of this proposal

rebased onto the latest heat/next branch

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #16835 heat-next for cbjchen mp280946
    LINT FAIL: lint-test failed

LINT Results (max last 2 lines):
make: *** [lint] Error 1
ERROR:root:Make target returned non-zero.

Full lint test output: http://paste.ubuntu.com/14438179/
Build: http://10.245.162.77:8080/job/charm_lint_check/16835/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #15723 heat-next for cbjchen mp280946
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/15723/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #15842 heat-next for cbjchen mp280946
    UNIT FAIL: unit-test failed

UNIT Results (max last 2 lines):
make: *** [test] Error 2
ERROR:root:Make target returned non-zero.

Full unit test output: http://paste.ubuntu.com/14445600/
Build: http://10.245.162.77:8080/job/charm_unit_test/15842/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #16962 heat-next for cbjchen mp280946
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16962/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8612 heat-next for cbjchen mp280946
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8612/

Revision history for this message
Liang Chen (cbjchen) wrote : Posted in a previous version of this proposal

Hi Liam,
Patch rebased onto the latest heat/next branch.
amulet tests and unit tests are fixed.

Thanks,
Liang

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #16963 heat-next for cbjchen mp280946
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/16963/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #15843 heat-next for cbjchen mp280946
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/15843/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8613 heat-next for cbjchen mp280946
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/14447806/
Build: http://10.245.162.77:8080/job/charm_amulet_test/8613/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #8617 heat-next for cbjchen mp280946
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8617/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #572 heat-next for cbjchen mp286025
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/572/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #486 heat-next for cbjchen mp286025
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/486/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #233 heat-next for cbjchen mp286025
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/233/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #635 heat-next for cbjchen mp286025
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/635/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #546 heat-next for cbjchen mp286025
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/546/

Revision history for this message
Liang Chen (cbjchen) wrote : Posted in a previous version of this proposal

rebased onto the latest heat-next branch.

Revision history for this message
Liang Chen (cbjchen) wrote : Posted in a previous version of this proposal

rebased onto the latest heat-next branch.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #636 heat-next for cbjchen mp286125
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/636/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #547 heat-next for cbjchen mp286125
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/547/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #242 heat-next for cbjchen mp286025
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15088403/
Build: http://10.245.162.36:8080/job/charm_amulet_test/242/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #243 heat-next for cbjchen mp286125
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15088510/
Build: http://10.245.162.36:8080/job/charm_amulet_test/243/

Revision history for this message
Liang Chen (cbjchen) wrote : Posted in a previous version of this proposal

The amulet failure is irreverent, and is addressed at https://code.launchpad.net/~hopem/charms/trusty/heat/lp1518975/+merge/285744.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #911 heat-next for cbjchen mp286612
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/911/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #811 heat-next for cbjchen mp286612
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/811/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #356 heat-next for cbjchen mp286612
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15129758/
Build: http://10.245.162.36:8080/job/charm_amulet_test/356/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #357 heat-next for cbjchen mp286612
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/15129986/
Build: http://10.245.162.36:8080/job/charm_amulet_test/357/

Revision history for this message
Liang Chen (cbjchen) wrote :

rebased onto Edward's patch to get rid off the amulet test failure.

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #812 heat-next for cbjchen mp286641
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/812/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #913 heat-next for cbjchen mp286641
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/913/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #358 heat-next for cbjchen mp286641
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/358/

Revision history for this message
Liam Young (gnuoy) wrote :

Thank you for this feature, it is a very welcome addition! Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches