Merge lp://staging/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 into lp://staging/ubuntu-filemanager-app
Proposed by
Carlos Jose Mazieri
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Alan Pope 🍺🐧🐱 🦄 | ||||
| Approved revision: | 585 | ||||
| Merged at revision: | 584 | ||||
| Proposed branch: | lp://staging/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 | ||||
| Merge into: | lp://staging/ubuntu-filemanager-app | ||||
| Diff against target: |
94 lines (+21/-10) 3 files modified
src/plugin/folderlistmodel/networklistworker.cpp (+17/-6) src/plugin/folderlistmodel/networklistworker.h (+3/-3) src/plugin/folderlistmodel/networklocation.cpp (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~carlos-mazieri/ubuntu-filemanager-app/fix-network-crash-1609051 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Jenkins Bot | continuous-integration | Approve | |
| Alan Pope 🍺🐧🐱 🦄 (community) | Approve | ||
| Renato Araujo Oliveira Filho (community) | Approve | ||
|
Review via email:
|
|||
Commit message
FIX the netwotk crash when Localtion::m_info is deleted in the main thread
Description of the change
FIX the netwotk crash when Localtion::m_info is deleted in the main thread because it is used in the worker thread, NetworkListWorker creates its own DirItemInfo instance and copies the data from Localtion::m_info to avoid that problem.
Location and descendant classes should be checked further to avoid deleting Localtion::m_info
To post a comment you must log in.
Revision history for this message
| Renato Araujo Oliveira Filho (renatofilho) wrote | # |
review:
Approve
Revision history for this message
| Jenkins Bot (ubuntu-core-apps-jenkins-bot) | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
code looks good and works nice.