Merge lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage into lp://staging/charms/trusty/apache2
Proposed by
Jacek Nykis
Status: | Rejected |
---|---|
Rejected by: | Haw Loeung |
Proposed branch: | lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage |
Merge into: | lp://staging/charms/trusty/apache2 |
Diff against target: |
61 lines (+20/-1) 4 files modified
README.md (+4/-0) config.yaml (+6/-0) hooks/hooks.py (+3/-1) metadata.yaml (+7/-0) |
To merge this branch: | bzr merge lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Haw Loeung | Disapprove | ||
Review Queue (community) | automated testing | Needs Fixing | |
Review Queue (community) | automated testing | Needs Fixing | |
Pen Gale (community) | Needs Fixing | ||
charmers | Pending | ||
Review via email:
|
Description of the change
This branch adds basic juju storage support to the apache2 charm. Tested with local provider (noop) and in OpenStack
To post a comment you must log in.
Unmerged revisions
- 75. By Chris Stratford
-
[jacek,r=chriss] Add "extra_ports" configuration option
- 74. By Jacek Nykis
-
Updated README.md
- 73. By Jacek Nykis
-
Add basic storage support
I ran into two failures when running bundletester on this charm:
1) "make lint" fails due to a missing flake8 dependency.
2) "make test" fails, as the new code breaks the mocking strategy for one of the existing tests.
Specifically, hooks.tests. ConfigChangedTe st.test_ config_ changed_ empty_site_ dir fails.
This is because the test patches out config_get, and has it return a mock config object. You can fix the test by doing one of the following:
1) Make the mock more complex, so that you can do config_get("foo"), and get back what you expect.
2) Change line 42 of hooks.py to something like the following:
set([int(p) for p in config_ get()[' extra_ports' ].split( )])
(You may then need to populate 'extra_ports' in the mock config with a list suitable for testing purposes.)