Merge lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage into lp://staging/charms/trusty/apache2

Proposed by Jacek Nykis
Status: Rejected
Rejected by: Haw Loeung
Proposed branch: lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage
Merge into: lp://staging/charms/trusty/apache2
Diff against target: 61 lines (+20/-1)
4 files modified
README.md (+4/-0)
config.yaml (+6/-0)
hooks/hooks.py (+3/-1)
metadata.yaml (+7/-0)
To merge this branch: bzr merge lp://staging/~canonical-sysadmins/charms/trusty/apache2/apache2-storage
Reviewer Review Type Date Requested Status
Haw Loeung Disapprove
Review Queue (community) automated testing Needs Fixing
Review Queue (community) automated testing Needs Fixing
Pen Gale (community) Needs Fixing
charmers Pending
Review via email: mp+298617@code.staging.launchpad.net

Description of the change

This branch adds basic juju storage support to the apache2 charm. Tested with local provider (noop) and in OpenStack

To post a comment you must log in.
75. By Chris Stratford

[jacek,r=chriss] Add "extra_ports" configuration option

Revision history for this message
Pen Gale (pengale) wrote :

I ran into two failures when running bundletester on this charm:

1) "make lint" fails due to a missing flake8 dependency.
2) "make test" fails, as the new code breaks the mocking strategy for one of the existing tests.

Specifically, hooks.tests.ConfigChangedTest.test_config_changed_empty_site_dir fails.

This is because the test patches out config_get, and has it return a mock config object. You can fix the test by doing one of the following:

1) Make the mock more complex, so that you can do config_get("foo"), and get back what you expect.
2) Change line 42 of hooks.py to something like the following:

    set([int(p) for p in config_get()['extra_ports'].split()])

(You may then need to populate 'extra_ports' in the mock config with a list suitable for testing purposes.)

Revision history for this message
Pen Gale (pengale) :
review: Needs Fixing
Revision history for this message
Pen Gale (pengale) wrote :

Testing failures aside, I was able to deploy this manually without errors, and the code looks solid.
Once "make test" passes, I am +1 on merging this.

Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5013/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4810/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5021/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5028/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4817/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4822/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5036/

review: Needs Fixing (automated testing)
Revision history for this message
Haw Loeung (hloeung) wrote :

Old so rejecting.

review: Disapprove

Unmerged revisions

75. By Chris Stratford

[jacek,r=chriss] Add "extra_ports" configuration option

74. By Jacek Nykis

Updated README.md

73. By Jacek Nykis

Add basic storage support

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches