Unity 8

Merge lp://staging/~canonical-platform-qa/unity8/nopy2 into lp://staging/unity8

nopy2
Merge into trunk

Proposed by Leo Arias on 2015-02-23

Status:

Merged

Approved by:

Albert Astals Cid on 2015-03-06

Approved revision:

1630

Merged at revision:

1680

Proposed branch:

lp://staging/~canonical-platform-qa/unity8/nopy2

Merge into:

lp://staging/unity8

Diff against target:

631 lines (+49/-99)

23 files modified

CODING (+5/-5)
cmake/modules/autopilot.cmake (+0/-8)
debian/control (+0/-8)
debian/rules (+2/-2)
tests/autopilot/setup.py (+2/-2)
tests/autopilot/unity8/application_lifecycle/tests/__init__.py (+2/-2)
tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py (+2/-4)
tests/autopilot/unity8/application_lifecycle/tests/test_url_dispatcher.py (+2/-2)
tests/autopilot/unity8/fixture_setup.py (+4/-4)
tests/autopilot/unity8/indicators/__init__.py (+1/-1)
tests/autopilot/unity8/indicators/tests/__init__.py (+1/-1)
tests/autopilot/unity8/indicators/tests/test_indicators.py (+2/-4)
tests/autopilot/unity8/process_helpers.py (+2/-9)
tests/autopilot/unity8/shell/__init__.py (+2/-2)
tests/autopilot/unity8/shell/emulators/create_interactive_notification.py (+2/-3)
tests/autopilot/unity8/shell/emulators/dash.py (+3/-3)
tests/autopilot/unity8/shell/fixture_setup.py (+2/-2)
tests/autopilot/unity8/shell/tests/__init__.py (+3/-3)
tests/autopilot/unity8/shell/tests/test_emulators.py (+4/-4)
tests/autopilot/unity8/shell/tests/test_lock_screen.py (+1/-9)
tests/autopilot/unity8/shell/tests/test_notifications.py (+4/-12)
tests/autopilot/unity8/shell/tests/test_tutorial.py (+2/-2)
tests/autopilot/unity8/shell/tests/test_upstart.py (+1/-7)

To merge this branch:

bzr merge lp://staging/~canonical-platform-qa/unity8/nopy2

Undecided

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Albert Astals Cid (community)			Approve on 2015-03-06
PS Jenkins bot (community)	continuous-integration	2015-02-23	Needs Fixing on 2015-03-03
Ubuntu Unity PS integration team		2015-03-03	Pending
Review via email: mp+250659@code.staging.launchpad.net

Commit message

Drop the support for python2 in autopilot tests.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

No required MPs.

* Did you perform an exploratory manual test run of your code change and any related functionality?

No, just ran the tests.

* Did you make sure that your branch does not contain spurious tags?

Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes.

* If you changed the UI, has there been a design review?

No UI changes.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5355/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-02-23:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5356/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-03:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/5380/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2015-03-06:

Are you doing the same for ubuntu-ui-toolkit-autopilot ? Otherwise it still pulls python 2.7 on the dependency chain for us.

Anyway this looks good

* Did you perform an exploratory manual test run of the code change and any related functionality?
Tests are still fine

* Did CI run pass?
No, but unrelated to this

* Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve

Revision history for this message

Leo Arias (elopio) wrote on 2015-03-06:

> Are you doing the same for ubuntu-ui-toolkit-autopilot ? Otherwise it still
> pulls python 2.7 on the dependency chain for us.

Not yet. We need to dig a little on all the suites before removing it from the toolkit.
Unity was easier because only a handful of suites depend on it.

Revision history for this message

Michał Sawicz (saviq) wrote on 2015-03-06:

Hey, while cleaning this up, IIUC we should replace libautopilot-qt dependency with autopilot-qt5 to prevent unnecessary qt4 installation.

Revision history for this message

Leo Arias (elopio) wrote on 2015-03-06:

> Hey, while cleaning this up, IIUC we should replace libautopilot-qt dependency
> with autopilot-qt5 to prevent unnecessary qt4 installation.

https://code.launchpad.net/~canonical-platform-qa/unity8/remove-qt4dep/+merge/252118

We also need to remove it from the toolkit: https://bugs.launchpad.net/ubuntu/+source/ubuntu-ui-toolkit/+bug/1429158