ueqa code proposals

Merge lp://staging/~canonical-platform-qa/ueqa-code-proposals/indicator-sound-control_player into lp://staging/ueqa-code-proposals

  1. indicator-sound-control_player
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 20
Merged at revision: 12
Proposed branch: lp://staging/~canonical-platform-qa/ueqa-code-proposals/indicator-sound-control_player
Merge into: lp://staging/ueqa-code-proposals
Prerequisite: lp://staging/~canonical-platform-qa/ueqa-code-proposals/indicator-messages-open_message
Diff against target: 95 lines (+81/-0)
3 files modified
proposals/indicator-sound-music-app.py (+12/-0)
proposals/indicator-sound.py (+21/-0)
proposals/indicator-sound.rst (+48/-0)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ueqa-code-proposals/indicator-sound-control_player
Reviewer Review Type Date Requested Status
Christopher Lee (community) Approve
Allan LeSage (community) Approve
Review via email: mp+242805@code.staging.launchpad.net

Commit message

Added a code proposal for an UX test to control the music player from the sound indicator.

To post a comment you must log in.
Revision history for this message
Allan LeSage (allanlesage) wrote :

Ok seems pretty basic after all although I know we were looking for the headphones solution--I like the basic version :) . Just needs some information for my context below pls. Also disregard my comment re: unityui file, I see the prereq above.

review: Needs Information
Revision history for this message
Leo Arias (elopio) :
lp://staging/~canonical-platform-qa/ueqa-code-proposals/indicator-sound-control_player updated
20. By Leo Arias

Use dbus mock.

Revision history for this message
Leo Arias (elopio) wrote :

I didn't want dbus because I wanted a test player, not to patch something like rhythmbox with a mock.
But we can implement the mpris interface with dbus mock. That will be less code than what I had in mind.

Revision history for this message
Allan LeSage (allanlesage) wrote :

Thanks for that adjustment.

review: Approve
Revision history for this message
Christopher Lee (veebers) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches