ubuntu-system-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/temp_config_files into lp://staging/ubuntu-system-tests

  1. temp_config_files
  2. Merge into trunk
Proposed by Sergio Cazzolato
Status: Work in progress
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-system-tests/temp_config_files
Merge into: lp://staging/ubuntu-system-tests
Diff against target: 358 lines (+103/-49)
8 files modified
README.rst (+9/-7)
debian/tests/control (+2/-2)
debian/tests/systemtests (+2/-0)
ubuntu_system_tests/command_line.py (+4/-5)
ubuntu_system_tests/config.py (+75/-26)
ubuntu_system_tests/selftests/test_command_line.py (+6/-5)
ubuntu_system_tests/selftests/test_config.py (+3/-3)
ubuntu_system_tests/systemtests.py (+2/-1)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/temp_config_files
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
Christopher Lee (community) Needs Fixing
Max Brustkern (community) Approve
PS Jenkins bot continuous-integration Approve
prod-platform-qa continuous-integration Pending
Sergio Cazzolato Pending
Review via email: mp+268839@code.staging.launchpad.net

Commit message

Fix to make possible to use temp config file for regular config data

To post a comment you must log in.
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

Still missing to fix the tests

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:154
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/689/
Executed test runs:
    FAILURE: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-amd64-ci/417/console
    FAILURE: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-armhf-ci/418/console
    FAILURE: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-i386-ci/417/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/689/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~canonical-platform-qa/ubuntu-system-tests/temp_config_files updated
155. By Sergio Cazzolato

Fixing unit tests

156. By Sergio Cazzolato

Fix leak and add documentation to readme.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:156
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/690/
Executed test runs:
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-amd64-ci/418
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-armhf-ci/419
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-wily-i386-ci/418

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-sanity-tests-ci/690/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Max Brustkern (nuclearbob) wrote :

Running without human interaction is my main use case. As an aside, the idea of the test runner altering it's config file every run is fairly concerning to me anyway; it seems like it could introduce race conditions when more than one instance runs simultaneously. Maybe this needs to be a bigger change discussed with more of the team?

Reply
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

Currently you are able to pass a config file as parameter for the tests execution.

What do you think about of pre-create all the config files that you need and then invoque the tests using the config file that you need?

Another alternative is that the test runner creates on the fly the config file and pass it as parameter to the test.

Reply
Revision history for this message
Max Brustkern (nuclearbob) wrote :

I think this should work well.

review: Approve
Reply
Revision history for this message
Christopher Lee (veebers) wrote :

Just a couple of minor things I came across when I was poking around.

review: Needs Fixing
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:156
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/10/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/32/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/33/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/37/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/10/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:156
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1106/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/352/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/350/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1828/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1106/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:156
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1144/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1919/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1144/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

156. By Sergio Cazzolato

Fix leak and add documentation to readme.

155. By Sergio Cazzolato

Fixing unit tests

154. By Sergio Cazzolato

Fix to make possible to use temp config file for regular config data

153. By Sergio Cazzolato

Adding fix to delete the config files just when these are temporal

152. By Max Brustkern

Don't delete config path

151. By Max Brustkern

Cleaning up temp files

150. By Max Brustkern

Remove remaining use of hardcoded /tmp file on host

149. By Max Brustkern

Added non-static config file on host

148. By Max Brustkern

Separate host and device config file paths

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: