ubuntu-system-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings into lp://staging/ubuntu-system-tests

system_settings
Merge into trunk

Proposed by Santiago Baldassin on 2016-08-23

Status:	Work in progress
Proposed branch:	lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings
Merge into:	lp://staging/ubuntu-system-tests
Prerequisite:	lp://staging/~canonical-platform-qa/ubuntu-system-tests/use_app_helper_phase_one
Diff against target:	797 lines (+218/-176) 22 files modified ubuntu_system_tests/helpers/application.py (+4/-0) ubuntu_system_tests/helpers/dialer_app/fixture_setup.py (+10/-7) ubuntu_system_tests/helpers/messaging/fixture_setup.py (+9/-6) ubuntu_system_tests/helpers/system_settings/__init__.py (+21/-41) ubuntu_system_tests/helpers/system_settings/_cpo.py (+2/-1) ubuntu_system_tests/helpers/system_settings/app.py (+39/-38) ubuntu_system_tests/helpers/system_settings/fixture_setup.py (+9/-5) ubuntu_system_tests/helpers/system_settings/gsettings.py (+72/-0) ubuntu_system_tests/helpers/system_settings/utils.py (+0/-13) ubuntu_system_tests/helpers/unity8/settings_wizard.py (+0/-11) ubuntu_system_tests/perftests/app_startup/test_app_startup.py (+2/-2) ubuntu_system_tests/tests/base_messaging.py (+4/-8) ubuntu_system_tests/tests/indicators/test_indicator_battery.py (+5/-3) ubuntu_system_tests/tests/indicators/test_indicator_bluetooth.py (+3/-4) ubuntu_system_tests/tests/indicators/test_indicator_datetime.py (+3/-4) ubuntu_system_tests/tests/indicators/test_indicator_network.py (+6/-8) ubuntu_system_tests/tests/indicators/test_indicator_sound.py (+3/-4) ubuntu_system_tests/tests/test_about_this_phone.py (+4/-2) ubuntu_system_tests/tests/test_messaging_sms.py (+3/-4) ubuntu_system_tests/tests/test_rotation.py (+12/-8) ubuntu_system_tests/tests/test_settings_wizard.py (+3/-4) ubuntu_system_tests/tests/test_sim_pin.py (+4/-3)
To merge this branch:	bzr merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
platform-qa-bot	continuous-integration		Needs Fixing on 2017-02-23
Sergio Cazzolato		2016-08-23	Needs Fixing on 2016-10-06
Richard Huddie (community)			Needs Fixing on 2016-08-31
prod-platform-qa	continuous-integration	2017-02-22	Pending
Review via email: mp+303690@code.staging.launchpad.net

Commit message

Use the application helper for system settings

Description of the change

This mp includes a rewrite of the system settings app to start using the application helper.
Gsettings methods were moved to a separate module and re-written to remove duplicate code and to make it easier to absorb possible changes in the keys or in the schemas
All the tests using the system settings were updated

@run_tests: ubuntu_system_tests.tests.indicators.test_indicator_battery ubuntu_system_tests.tests.indicators.test_indicator_bluetooth ubuntu_system_tests.tests.indicators.test_indicator_datetime ubuntu_system_tests.tests.indicators.test_indicator_network.NetworkIndicatorTestCase ubuntu_system_tests.tests.indicators.test_indicator_sound.SoundIndicatorTestCase ubuntu_system_tests.tests.test_rotation

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:425
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/442/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3123/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3123/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/620/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/442/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings updated on 2016-08-23

426. By Santiago Baldassin on 2016-08-23: fixing import error

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

FAILED: Continuous integration, rev:426
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/443/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3124
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3124/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3124
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3124/artifact/work/output/*zip*/output.zip
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/ust_rc-proposed_krillin_sanity_test/122/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/621/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/443/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

PASSED: Continuous integration, rev:426
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/448/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3131
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3131/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3131
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3131/artifact/work/output/*zip*/output.zip
    UNSTABLE: https://platform-qa-jenkins.ubuntu.com/job/ust_rc-proposed_krillin_sanity_test/127
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/628/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/448/rebuild

review: Approve (continuous-integration)

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/448/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

PASSED: Continuous integration, rev:426
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/449/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3133
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3133/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3133
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3133/artifact/work/output/*zip*/output.zip
    UNSTABLE: https://platform-qa-jenkins.ubuntu.com/job/ust_rc-proposed_krillin_sanity_test/128
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/630/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/449/rebuild

review: Approve (continuous-integration)

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-23:

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/449/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings updated on 2016-08-24

427. By Santiago Baldassin on 2016-08-24: restoring scopes.json

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-24:

FAILED: Continuous integration, rev:427
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/459/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3147/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3147/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/641/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/459/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~canonical-platform-qa/ubuntu-system-tests/system_settings updated on 2016-08-25

428. By Santiago Baldassin on 2016-08-25: Merge from trunk

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-08-25:

FAILED: Continuous integration, rev:428
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/475/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3169/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3169/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/662/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/475/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Sergio Cazzolato (sergio-j-cazzolato) wrote on 2016-08-25:

I saw this error:

Traceback (most recent call last):
File "/tmp/adt-run.SsLom4/build.jyX/real-tree/ubuntu_system_tests/tests/indicators/test_indicator_bluetooth.py", line 44, in test_bluetooth_settings_item_open_correct_page
system_settings.is_settings_page_visible(BLUETOOTH_SETTINGS_PAGE)
AttributeError: 'SystemSettings' object has no attribute 'is_settings_page_visible'
}}}