ubuntu-system-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/shared-cpo-data into lp://staging/ubuntu-system-tests

  1. shared-cpo-data
  2. Merge into trunk
Proposed by Richard Huddie
Status: Work in progress
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-system-tests/shared-cpo-data
Merge into: lp://staging/ubuntu-system-tests
Diff against target: 210 lines (+85/-23)
4 files modified
ubuntu_system_tests/helpers/data.py (+36/-14)
ubuntu_system_tests/helpers/file_system.py (+3/-0)
ubuntu_system_tests/helpers/indicators/battery.json (+29/-0)
ubuntu_system_tests/helpers/indicators/battery.py (+17/-9)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/shared-cpo-data
Reviewer Review Type Date Requested Status
Michał Sawicz (community) Needs Information
Santiago Baldassin (community) Needs Information
Review via email: mp+294934@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~canonical-platform-qa/ubuntu-system-tests/shared-cpo-data updated
388. By Richard Huddie

Use data file names for accessing properties.

389. By Richard Huddie

simplify the data structure.

390. By Richard Huddie

Simplify the data structure.

391. By Richard Huddie

Move the json file to helpers dir.

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Hi Richard, thanks for mp. I just have a couple of comments about the use of a global variable to keep the metadata and another one about always loading all the matadata for all the helpers. Would you please let me know your thoughts about it?

review: Needs Information
Reply
Revision history for this message
Richard Huddie (rhuddie) wrote :

> Hi Richard, thanks for mp. I just have a couple of comments about the use of a
> global variable to keep the metadata and another one about always loading all
> the matadata for all the helpers. Would you please let me know your thoughts
> about it?

Thanks for taking a look. I was also thinking about how to structure the data. I think it makes sense for a metadata file to exist for each helper file. The helper would then need to only load the corresponding metadata from a single file. The only potential problem I see with this is that if you have an object defined in one file, a helper in another file might also want to include that, rather than having to re-define it again locally. This would require all the helpers data to be loaded at once.

This is still very much a work-in-progress so, we'll have to see how useful (or not) this might actually be. I'll give this approach a try and see how it goes.

Reply
lp://staging/~canonical-platform-qa/ubuntu-system-tests/shared-cpo-data updated
392. By Richard Huddie

Merge from trunk.

393. By Richard Huddie

Can load metadata for a single file.

Revision history for this message
Michał Sawicz (saviq) :
review: Needs Information
Reply
Revision history for this message
Richard Huddie (rhuddie) wrote :

Reply comments below.

Reply

Unmerged revisions

393. By Richard Huddie

Can load metadata for a single file.

392. By Richard Huddie

Merge from trunk.

391. By Richard Huddie

Move the json file to helpers dir.

390. By Richard Huddie

Simplify the data structure.

389. By Richard Huddie

simplify the data structure.

388. By Richard Huddie

Use data file names for accessing properties.

387. By Richard Huddie

Add first attempt at importing data for cpo.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: