ubuntu-system-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/fix_telegram into lp://staging/ubuntu-system-tests

  1. fix_telegram
  2. Merge into trunk
Proposed by Santiago Baldassin
Status: Work in progress
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-system-tests/fix_telegram
Merge into: lp://staging/ubuntu-system-tests
Diff against target: 276 lines (+56/-129)
2 files modified
ubuntu_system_tests/helpers/telegram/_cpo.py (+47/-119)
ubuntu_system_tests/tests/test_telegram.py (+9/-10)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-system-tests/fix_telegram
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
Sergio Cazzolato Approve
Richard Huddie (community) Needs Fixing
prod-platform-qa continuous-integration Pending
Review via email: mp+306207@code.staging.launchpad.net

Commit message

Re-writing telegram cpo and test case

Description of the change

This merge proposal re-writes the telegram cpo to avoid the access of the root instance since it is making the app to crash when it is accessed more than once.

One line methods were replaced by direct calls when it is needed to make the code more readable

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:469
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/712/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3467
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3467/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3467
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3467/artifact/work/output/*zip*/output.zip
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/976/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/712/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Richard Huddie (rhuddie) wrote :

A few minor points below.

review: Needs Fixing
Reply
Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

Thanks Richard. all comments were addressed

Reply
lp://staging/~canonical-platform-qa/ubuntu-system-tests/fix_telegram updated
470. By Santiago Baldassin

Addressing comments from the reviews

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:470
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/735/
Executed test runs:
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3497
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-amd64-package/3497/artifact/work/output/*zip*/output.zip
    SUCCESS: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3497
        deb: https://platform-qa-jenkins.ubuntu.com/job/build-wily-i386-package/3497/artifact/work/output/*zip*/output.zip
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1008/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/735/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

Code lgtm

review: Approve
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:470
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1075/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/307/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/305/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1696/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1075/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:470
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1092/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/331/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/329/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1802/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1092/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:470
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1121/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/376/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/374/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1857/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/ubuntu-system-tests-ci/1121/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

470. By Santiago Baldassin

Addressing comments from the reviews

469. By Santiago Baldassin

Re-writing telegram cpo and test case

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: