Online Accounts setup for Ubuntu Touch

Merge lp://staging/~canonical-platform-qa/ubuntu-system-settings-online-accounts/launch_fixture into lp://staging/ubuntu-system-settings-online-accounts

  1. launch_fixture
  2. Merge into trunk
Proposed by Leo Arias
Status: Work in progress
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-system-settings-online-accounts/launch_fixture
Merge into: lp://staging/ubuntu-system-settings-online-accounts
Diff against target: 107 lines (+62/-18)
2 files modified
tests/autopilot/online_accounts_ui/fixture_setup.py (+57/-0)
tests/autopilot/online_accounts_ui/tests/__init__.py (+5/-18)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-system-settings-online-accounts/launch_fixture
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Víctor R. Ruiz (community) Approve
Online Accounts Pending
Review via email: mp+226851@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-07-11.

Commit message

Moved the launcher to a fixture so it can be reused outside of the testcase.

To post a comment you must log in.
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote : Posted in a previous version of this proposal

Overall, looks good to me. Needs fixing: Classes and methods need docstrings. And the name of the class (LaunchBinaryOnlineAccountsUI) conflicts with the one used in /tests/__init__.py (LaunchOnlineAccountsUI).

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) wrote : Posted in a previous version of this proposal

> Overall, looks good to me. Needs fixing: Classes and methods need docstrings.

Added.

> And the name of the class (LaunchBinaryOnlineAccountsUI) conflicts with the
> one used in /tests/__init__.py (LaunchOnlineAccountsUI).

Good catch, I forgot to update it there.

Thanks.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:135
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/139/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1885
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/32
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/32/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/32
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2984
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2984/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9719

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/139/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal

PASSED: Continuous integration, rev:138
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/140/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/1894
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/33
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/33/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/33
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2149
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2994
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/2994/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9727

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/140/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:138
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/141/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2031
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/34
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-armhf-ci/34/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/34
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2266
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3157
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3157/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/9885

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/141/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

LGTM.

review: Approve
Reply
lp://staging/~canonical-platform-qa/ubuntu-system-settings-online-accounts/launch_fixture updated
139. By Leo Arias

Merged with trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:139
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-ci/157/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/4685
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-amd64-ci/50/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-online-accounts-utopic-i386-ci/50
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/4460
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5937
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/5937/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/13014

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-online-accounts-ci/157/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Leo Arias (elopio) wrote :

I'm sure this used to work when I proposed it a couple of months ago :(

Reply

Unmerged revisions

139. By Leo Arias

Merged with trunk.

138. By Leo Arias

Fixed the online accounts ui fixture name.

137. By Leo Arias

Added a comment.

136. By Leo Arias

Added a comment.

135. By Leo Arias

Moved the launcher to a fixture so it can be reused outside of the testcase.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches