ubuntu-power-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/shared-setup into lp://staging/ubuntu-power-tests

  1. shared-setup
  2. Merge into trunk
Proposed by Federico Gimenez
Status: Merged
Approved by: Max Brustkern
Approved revision: 9
Merged at revision: 8
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-power-tests/shared-setup
Merge into: lp://staging/ubuntu-power-tests
Prerequisite: lp://staging/~canonical-platform-qa/ubuntu-power-tests/initial-commit-of-existing
Diff against target: 76 lines (+28/-2)
3 files modified
README (+1/-1)
power-meter-tests/test.sh (+9/-0)
power-meter-tests/test_upload.sh (+18/-1)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/shared-setup
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Max Brustkern (community) Approve
Review via email: mp+255337@code.staging.launchpad.net

Commit message

Common setup steps: disable wizard and network setup

Description of the change

Common setup steps remaining for the shared setup/provisioning card. Currently implements the wizard deactivation and network setup, for the HERE maps we may use a custom image like ubuntu-touch/vivid-proposed-customized-here

To post a comment you must log in.
lp://staging/~canonical-platform-qa/ubuntu-power-tests/shared-setup updated
7. By Federico Gimenez

Added network setup

8. By Federico Gimenez

Improved function comments

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I'm wondering if we can be using phablet-network for this.

review: Needs Information
lp://staging/~canonical-platform-qa/ubuntu-power-tests/shared-setup updated
9. By Federico Gimenez

Removed nmcli fallback

Revision history for this message
Federico Gimenez (fgimenez) wrote :

I've removed the || true in the nmcli call. Regarding the use of nmcli instead of phablet-network, it's related to this bug [1], the fix hasn't landed yet in phablet-tools.

Cheers!

[1] https://bugs.launchpad.net/ubuntu/+source/phablet-tools/+bug/1427559

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good. I hope that can land soon.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: