ubuntu-power-tests

Merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/location-access into lp://staging/ubuntu-power-tests

  1. location-access
  2. Merge into trunk
Proposed by Richard Huddie
Status: Merged
Merged at revision: 9
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-power-tests/location-access
Merge into: lp://staging/ubuntu-power-tests
Diff against target: 67 lines (+13/-4)
3 files modified
README (+2/-2)
debian/tests/tc-powermeter-05 (+9/-1)
power-meter-tests/test_upload.sh (+2/-1)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-power-tests/location-access
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
PS Jenkins bot continuous-integration Approve
Brendan Donegan (community) Approve
Review via email: mp+257362@code.staging.launchpad.net

Commit message

Disable the location access prompt for tc-powermeter-05.

Description of the change

Disable the location access prompt for tc-powermeter-05.

I executed this test using:
adt-run --testname tc-powermeter-05 -B --unbuilt-tree=. --- ssh -s adb -- -p 0000

Note that I have not been able to run through test_upload.sh as this requires the power-meter setup.

To post a comment you must log in.
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Small inline comment. Also I would make sure the README is updated to take into account this change

review: Needs Fixing
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Missed the diff comment

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I'd still like to see the bashism removed, but won't insist. So +1 from me

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:11
http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-ci/8/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-power-tests-vivid-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-power-tests-ci/8/rebuild

review: Approve (continuous-integration)
Revision history for this message
Max Brustkern (nuclearbob) wrote :

This works for me. Should we go ahead and merge, or should I submit a patch to remove the bashisms?

review: Approve
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Max - if you think they should be then I would go for it

On Tue, Apr 28, 2015 at 2:04 PM, Max Brustkern <email address hidden>
wrote:

> Review: Approve
>
> This works for me. Should we go ahead and merge, or should I submit a
> patch to remove the bashisms?
> --
>
> https://code.launchpad.net/~canonical-platform-qa/ubuntu-power-tests/location-access/+merge/257362
> You are reviewing the proposed merge of
> lp:~canonical-platform-qa/ubuntu-power-tests/location-access into
> lp:ubuntu-power-tests.
>

Revision history for this message
Richard Huddie (rhuddie) wrote :

Hi Max, it would be easier for you to verify those changes in your environment, so do go ahead and make the update.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

I merged these changes and removed bashisms here:
lp:~nuclearbob/ubuntu-power-tests/no-wifi-in-test-upload

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: