Code review comment for lp://staging/~canonical-platform-qa/ubuntu-ota-tests/check-for-running-service

Revision history for this message
Christopher Lee (veebers) wrote :

Thanks Barry I've made the suggested changes.

I came across an issue today where the example test would fail due to the process not being exited right at that moment. As a fix I'm using some functionality from autopilot, but I'm concerned by this for som ereasons:
  1. This pulls in autopilot as a dep. Not sure if we want to do that for the core parts of the scripts.
  2. There may be a better way to resolve the issue I use ap for.

I agree re: the packaging, we can iterate over it this week. We need to get the base code down so we can continue.

I'll take a closer look at what systemimage provides. Are you suggesting that there is code there already I can use in this instance?

« Back to merge proposal