Merge lp://staging/~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience into lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests

Proposed by Omer Akram
Status: Needs review
Proposed branch: lp://staging/~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience
Merge into: lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests
Diff against target: 83 lines (+56/-1)
3 files modified
debian/control (+2/-0)
ubuntu_experience_tests/helpers.py (+1/-1)
ubuntu_experience_tests/tests/test_user_experiences.py (+53/-0)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/ubuntu-autopilot-tests/launcher_messaging_experience
Reviewer Review Type Date Requested Status
Brendan Donegan (community) Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Leo Arias (community) Needs Fixing
Review via email: mp+225465@code.staging.launchpad.net

Commit message

Automate Launcher to Messaging App experience.

To post a comment you must log in.
Revision history for this message
Omer Akram (om26er) wrote :

While the code is ready, this branch depends on four other branches to be merged.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
27. By Omer Akram

commit in working state, will need to adapt to use helpers from address-book-app once they are moved there.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

103 + messaging_app = helpers.get_proxy_object_by_process_name(
104 + 'messaging-app',
105 + emulator_base=messaging_emulators.MainView
106 + )

Just as with Brendan's branch, the only emulator_base that we must be using is the one from the toolkit. Definitely not a MainView. There's something wrong here.

107 + messaging_app.start_new_message()
108 + messaging_app.type_contact_phone_num('3333333')
109 + messaging_app.type_message('Hello user!')
110 + messaging_app.click_send_button()

This needs to be wrapped in a helper on the messaging app that's called something like: def send_message(recipients, text)

review: Needs Fixing
28. By Omer Akram

don;t alter launcher icons go with stock

29. By Omer Akram

python3 ready

30. By Omer Akram

revert the change to get_proxy_object_by_process_name

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
31. By Omer Akram

use the helper from message_app to send message instead of duplicating the code

32. By Omer Akram

use helper from the messaging_app to send message

33. By Omer Akram

flake8

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
34. By Omer Akram

also depend on messaging-app-autopilot

35. By Omer Akram

create a method to add contact

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

I'm missing how this code implements the use case in the linked bug:
https://bugs.launchpad.net/ubuntu-autopilot-tests/+bug/1328921. It's supposed to use the quicklist, but as far as I can tell it just fills in the details and sends the message.

review: Needs Information
36. By Omer Akram

adapt to contact fixture in address-book-service instead of doing that stuff in our code

37. By Omer Akram

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
38. By Omer Akram

fix test as suggested by brendand

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

What is this 'select' option in send_message? I don't see it in messaging-app trunk. I think rather than just calling send_message you want to use the helper to compose a new message (start_new_message), then type in the MultiRecipientInput. You'll need a helper for that based on the one I'm adding here: https://code.launchpad.net/~canonical-platform-qa/messaging-app/more_helpers_test/+merge/227781. That's depending on your address-book-service helper so once that gets merged we can merge that one, then merge this one.

review: Needs Fixing

Unmerged revisions

38. By Omer Akram

fix test as suggested by brendand

37. By Omer Akram

merge trunk

36. By Omer Akram

adapt to contact fixture in address-book-service instead of doing that stuff in our code

35. By Omer Akram

create a method to add contact

34. By Omer Akram

also depend on messaging-app-autopilot

33. By Omer Akram

flake8

32. By Omer Akram

use helper from the messaging_app to send message

31. By Omer Akram

use the helper from message_app to send message instead of duplicating the code

30. By Omer Akram

revert the change to get_proxy_object_by_process_name

29. By Omer Akram

python3 ready

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches