Merge lp://staging/~canonical-platform-qa/ubuntu-autopilot-tests/add-contact-with-photo into lp://staging/ubuntu-autopilot-tests/ubuntu-experience-tests

FAILED: Continuous integration, rev:39
http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/30/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2662/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-amd64-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-armhf-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/ubuntu-autopilot-tests-ubuntu-experience-tests-utopic-i386-ci/30/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3905/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-autopilot-tests-ubuntu-experience-tests-ci/30/rebuild

100 + self.unity.search('Contacts')
101 + label = self.unity_proxy.select_single(
102 + 'Label', objectName='titleLabel', text='Contacts')

This is about to change because the search is no longer done in the unity main view. It's done on the dash which is a separate app.
So for this test you will have to either restart the dash instead of restarting unity and do self.dash.search, or launch the app from the launcher which is work in progress.
Any way you choose, you'll have to wait. Sorry. I'll ask for your review on the unity branches once they are ready, that will speed things a little and you will see what I'm talking about.

151 + # tap the photo icon to launch the gallery app
152 + self.addCleanup(os.system, 'ubuntu-app-stop gallery-app')

Why is this needed? I thought that the gallery app would be killed as soon as the picture was selected.

157 + # wait for transition back to contacts app
158 + contact_editor.wait_to_stop_moving()

This seems a little weird. wait_to_stop_moving waits for the flickable to stop flicking, right? How is that related to the picture transfer? I might just be getting it wrong.

This looks really good. I'm eager to get it running. Thanks Richard.

> 100 + self.unity.search('Contacts')
> 101 + label = self.unity_proxy.select_single(
> 102 + 'Label', objectName='titleLabel', text='Contacts')
>
> This is about to change because the search is no longer done in the unity main
> view. It's done on the dash which is a separate app.
> So for this test you will have to either restart the dash instead of
> restarting unity and do self.dash.search, or launch the app from the launcher
> which is work in progress.
> Any way you choose, you'll have to wait. Sorry. I'll ask for your review on
> the unity branches once they are ready, that will speed things a little and
> you will see what I'm talking about.
>
> 151 + # tap the photo icon to launch the gallery app
> 152 + self.addCleanup(os.system, 'ubuntu-app-stop gallery-app')
>
> Why is this needed? I thought that the gallery app would be killed as soon as
> the picture was selected.
>
> 157 + # wait for transition back to contacts app
> 158 + contact_editor.wait_to_stop_moving()
>
> This seems a little weird. wait_to_stop_moving waits for the flickable to stop
> flicking, right? How is that related to the picture transfer? I might just be
> getting it wrong.
>
> This looks really good. I'm eager to get it running. Thanks Richard.

Hi Leo,

Note taken to update the search function when it is landed.

The clean-up action for the gallery-app was added in case of any termination of the test whilst the gallery-app is open. Under normal circumstances it would not be needed as the gallery-app should shut down automatically, but I just added it for extra safety.

The wait_to_stop_moving() was added because there is a transition effect when you return from gallery-app to address-book-app. I saw some failures where the test was trying to proceed whilst this was happening, but using this ensured that the UI had settled down before proceeding.

Thanks for your comments. I'll be glad too to get this one finally landed!

I get it, thanks for the info.