Merge lp://staging/~canonical-platform-qa/qakit/test-execution-gathering into lp://staging/qakit

Proposed by Allan LeSage
Status: Merged
Approved by: Christopher Lee
Approved revision: 31
Merged at revision: 22
Proposed branch: lp://staging/~canonical-platform-qa/qakit/test-execution-gathering
Merge into: lp://staging/qakit
Diff against target: 811 lines (+720/-3)
7 files modified
qakit/metrics/practitest/instances.py (+102/-0)
qakit/metrics/practitest/testsets.py (+144/-0)
qakit/metrics/test_execution.py (+131/-0)
qakit/metrics/tests/test_practitest_instances.py (+113/-0)
qakit/metrics/tests/test_practitest_testsets.py (+80/-0)
qakit/metrics/tests/test_test_execution.py (+99/-0)
qakit/practitest/practitest.py (+51/-3)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/qakit/test-execution-gathering
Reviewer Review Type Date Requested Status
Christopher Lee (community) Approve
Review via email: mp+275778@code.staging.launchpad.net

Commit message

Gather test execution data from PractiTest.

Description of the change

Gather test execution data from PractiTest and deposit in a mongodb database.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

Looking good, a couple of inline comments.

review: Needs Fixing
25. By Allan LeSage

De-shebangify.

26. By Allan LeSage

Adjust count insertion.

27. By Allan LeSage

Adjust a warning log message.

28. By Allan LeSage

Adjust a docstring to call out list.

29. By Allan LeSage

Move no last testset logic up a level, some whitespace and naming changes thrown in.

30. By Allan LeSage

Resolve flake8 config conflict, remove NOQA.

31. By Allan LeSage

Just raise.

Revision history for this message
Allan LeSage (allanlesage) wrote :

Addressed in numbered revisions, thanks Chris.

Revision history for this message
Christopher Lee (veebers) wrote :

LGTM, thanks for the changes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: