qakit

Merge lp://staging/~canonical-platform-qa/qakit/fix-trello-since into lp://staging/qakit

  1. fix-trello-since
  2. Merge into trunk
Proposed by Allan LeSage
Status: Merged
Approved by: Christopher Lee
Approved revision: 26
Merged at revision: 25
Proposed branch: lp://staging/~canonical-platform-qa/qakit/fix-trello-since
Merge into: lp://staging/qakit
Diff against target: 28 lines (+2/-4)
2 files modified
qakit/metrics/landings.py (+1/-3)
qakit/metrics/practitest/testsets.py (+1/-1)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/qakit/fix-trello-since
Reviewer Review Type Date Requested Status
Christopher Lee (community) Approve
Review via email: mp+276715@code.staging.launchpad.net

Description of the change

We were consistently digging all the way back to 2014 which retrieving from Trello, this explains why :) .

To post a comment you must log in.
lp://staging/~canonical-platform-qa/qakit/fix-trello-since updated
26. By Allan LeSage

Don't re-set to None, thanks.

Revision history for this message
Christopher Lee (veebers) wrote :

LGTM, if on date supplied need to pass None to the db args so they can figure out the last action and go from there.

review: Approve
lp://staging/~canonical-platform-qa/qakit/fix-trello-since updated
27. By Allan LeSage

Correct last_testset_id assignment.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: