Merge lp://staging/~canonical-platform-qa/mediaplayer-app/fix1359040-skip_seekbar into lp://staging/mediaplayer-app

Proposed by Leo Arias
Status: Merged
Approved by: Jim Hodapp
Approved revision: 268
Merged at revision: 280
Proposed branch: lp://staging/~canonical-platform-qa/mediaplayer-app/fix1359040-skip_seekbar
Merge into: lp://staging/mediaplayer-app
Diff against target: 79 lines (+17/-12)
1 file modified
tests/autopilot/mediaplayer_app/tests/test_player_with_video.py (+17/-12)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/mediaplayer-app/fix1359040-skip_seekbar
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Approve
Chris Gagnon (community) Approve
Review via email: mp+231508@code.staging.launchpad.net

Commit message

Skip the seekbar tests on the devices that do not have space for it.

Description of the change

Are there any related MPs required for this MP to build/function as expected? Please list.

No related MPs.

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)

It is.

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?

No functionality changes. Only exploratory testing was to identify the diferences between the device runs.

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/<package-name>) on device or emulator?

No need to run manual tests. I just ran the automated tests on my devices and desktop.

If you changed the UI, was the change specified/approved by design?

No UI changes.

If you changed UI labels, did you update the pot file?

No UI changes.

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?

No packaging changes.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
266. By Leo Arias

Typo.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Chris Gagnon (chris.gagnon) wrote :

lgtm

review: Approve
267. By Leo Arias

Merged with trunk.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) :
268. By Leo Arias

Updated the copyright years.

Revision history for this message
Jim Hodapp (jhodapp) wrote :

Approved, looks good thanks.

review: Approve (code)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches