Merge lp://staging/~canonical-platform-qa/checkbox/lbuilding-on-oauth-community-testing into lp://staging/checkbox
Proposed by
Christopher Lee
| Status: | Rejected |
|---|---|
| Rejected by: | Maciej Kisielewski |
| Proposed branch: | lp://staging/~canonical-platform-qa/checkbox/lbuilding-on-oauth-community-testing |
| Merge into: | lp://staging/checkbox |
| Prerequisite: | lp://staging/~kissiel/checkbox/oauth-transport |
| Diff against target: |
583 lines (+461/-9) 8 files modified
checkbox-touch/checkbox-touch.qml (+20/-1) checkbox-touch/components/CheckboxTouchApplication.qml (+12/-3) checkbox-touch/py/checkbox_touch.py (+12/-3) checkbox-touch/settings-oauth.json (+13/-0) checkbox-touch/sso-login.qml (+186/-0) checkbox-touch/sso_login.py (+146/-0) plainbox/plainbox/impl/session/assistant.py (+29/-2) plainbox/plainbox/impl/transport.py (+43/-0) |
| To merge this branch: | bzr merge lp://staging/~canonical-platform-qa/checkbox/lbuilding-on-oauth-community-testing |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Maciej Kisielewski (community) | Disapprove | ||
|
Review via email:
|
|||
Commit message
Adding SSO/OAuth for uploading for Ubuntu community testing.
Description of the change
A branch that builds on https:/
To post a comment you must log in.
Revision history for this message
| Christopher Lee (veebers) wrote | # |
Unmerged revisions
- 4016. By Christopher Lee
-
Ensure sensitive OAuth details aren't printed to log.
- 4015. By Christopher Lee
-
Minor fix for sso qml
- 4014. By Christopher Lee
-
Use the correct service url in the json settings.
- 4013. By Christopher Lee
-
Small niceity, tabbing between email and password fields.
- 4012. By Christopher Lee
-
QML Dialog behaves better (greys out during request, closes properly).
- 4011. By Christopher Lee
-
Working against staging. Still needs qml error fixed/
- 4010. By Christopher Lee
-
Working initial workflow (without actuall signing/
authentication) - 4009. By Christopher Lee
-
Merge changes in trunk.
- 4008. By Maciej Kisielewski
-
fix for sso-login dialog
- 4007. By Maciej Kisielewski
-
add sso-login dialog
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Oops, I realise now at EOD that this merges don't match the projects expectation. I will fix this in my morning, sorry. (the code won't change between then and now).