Autopilot

Merge lp://staging/~canonical-platform-qa/autopilot/sandbox-leaks into lp://staging/autopilot

  1. sandbox-leaks
  2. Merge into trunk
Proposed by Vincent Ladeuil
Status: Needs review
Proposed branch: lp://staging/~canonical-platform-qa/autopilot/sandbox-leaks
Merge into: lp://staging/autopilot
Diff against target: 126 lines (+30/-7)
2 files modified
autopilot/tests/functional/test_input_stack.py (+29/-6)
bin/autopilot3-sandbox-run (+1/-1)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/autopilot/sandbox-leaks
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Approve
Christopher Lee (community) Needs Fixing
prod-platform-qa continuous-integration Pending
Review via email: mp+259939@code.staging.launchpad.net

Commit message

Skip the input stack tests that leak when run under the sandbox

Description of the change

While attempting to run the autopilot self test suite, I ran into tests that use the input stack of my laptop.

This is quite unexpected and inconvenient ;)

This is mainly caused by test using the autopilot.input.Touch class which ignores/is unaware of running into a nested X server. As discussed with Chris, there may be ways to make the class detect this case and redirect the events in the right place.

This proposal just skip these tests as a first line of defense.

To post a comment you must log in.
Revision history for this message
Christopher Lee (veebers) wrote :

Some questions and comments inline.

Being pedantic, could you separate out the spelling mistake fixes as they aren't relevant to this MP-fix.

review: Needs Fixing
Reply
lp://staging/~canonical-platform-qa/autopilot/sandbox-leaks updated
560. By Vincent Ladeuil

Use a better name for the skipper ;)

561. By Vincent Ladeuil

Skip parametrized tests from setUp() so they still appear in autopilot list.

562. By Vincent Ladeuil

Remove teh tyop fix, it will be part of a different proposal.

563. By Vincent Ladeuil

Stop import 'skip' since it wasn't used in the end.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Answers inline, I think all remarks are addressed with the latest revision.

Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:563
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1075/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/6/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2945
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2522
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2943
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2943/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/20738

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1075/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/8/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/8/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/8/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/121/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/357/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/355/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1833/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/121/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/130/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/388/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/386/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1875/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/130/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/139/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/417/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/417/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1914/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/139/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/148/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/443/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/443/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1944/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/148/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:563
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/157/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/457/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/457/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1962/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/157/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

563. By Vincent Ladeuil

Stop import 'skip' since it wasn't used in the end.

562. By Vincent Ladeuil

Remove teh tyop fix, it will be part of a different proposal.

561. By Vincent Ladeuil

Skip parametrized tests from setUp() so they still appear in autopilot list.

560. By Vincent Ladeuil

Use a better name for the skipper ;)

559. By Vincent Ladeuil

Fix typo.

558. By Vincent Ladeuil

Define the snadbox detection in a single place.

557. By Vincent Ladeuil

Some input tests leak when run under xvfb/Xephyr, skip them as a first line of defense.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches