Autopilot

Merge lp://staging/~canonical-platform-qa/autopilot/pdf-build into lp://staging/autopilot

pdf-build
Merge into trunk

Proposed by Allan LeSage on 2015-01-22

Status:	Needs review
Proposed branch:	lp://staging/~canonical-platform-qa/autopilot/pdf-build
Merge into:	lp://staging/autopilot
Diff against target:	96 lines (+17/-6) 3 files modified debian/control (+3/-0) debian/rules (+9/-1) docs/man.rst (+5/-5)
To merge this branch:	bzr merge lp://staging/~canonical-platform-qa/autopilot/pdf-build
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
platform-qa-bot	continuous-integration		Approve on 2016-01-19
PS Jenkins bot	continuous-integration		Approve on 2015-01-26
Martin Pitt (community)			Needs Fixing on 2015-01-23
Thomi Richards (community)		2015-01-22	Approve on 2015-01-22
Review via email: mp+247249@code.staging.launchpad.net

Commit message

Provide pdf build.

Description of the change

Provide pdf-building via LaTeX.

Required minor modification for a unicode char unprovided-for. Where/how would we want to install the result?

This'll be on hold until I fix a noodly Makefile/bash issue (marked as FIXME in debian/rules), but wanting to get some feedback.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-22:

FAILED: Continuous integration, rev:529
http://jenkins.qa.ubuntu.com/job/autopilot-ci/994/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/57/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/74/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/499/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/994/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~canonical-platform-qa/autopilot/pdf-build updated on 2015-01-22

530. By Allan LeSage on 2015-01-22: Correct .svg extensions.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-22:

FAILED: Continuous integration, rev:530
http://jenkins.qa.ubuntu.com/job/autopilot-ci/995/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/58/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/76/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/501/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/995/rebuild

review: Needs Fixing (continuous-integration)

lp://staging/~canonical-platform-qa/autopilot/pdf-build updated on 2015-01-22

531. By Allan LeSage on 2015-01-22: Revert whitespace change.
532. By Allan LeSage on 2015-01-22: Makefile hackery to convert .svgs to .pdf, revert wildcard .svg change, add imagemagick build-dep.
533. By Allan LeSage on 2015-01-22: Merge trunk.
534. By Allan LeSage on 2015-01-22: Clean up debian/rules comments :/ .

Revision history for this message

Allan LeSage (allanlesage) wrote on 2015-01-22:

To build/test, just do a normal debian build--the .pdf arrives in build/sphinx/latex/Autopilot.pdf , else just follow the steps listed in debian/rules. Note that you'll need the added dependencies.

Also note that the man.rst changes convert that unicode em-dash to a normal hyphen, wasn't supported during the LaTeX generation.

lp://staging/~canonical-platform-qa/autopilot/pdf-build updated on 2015-01-22

535. By Allan LeSage on 2015-01-22: debian/control whitespace fix.

Revision history for this message

Thomi Richards (thomir-deactivatedaccount) wrote on 2015-01-22:

LGTM, but I'd like to see someone review the packaging bits.

Cheers,

review: Approve

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-22:

FAILED: Continuous integration, rev:534
http://jenkins.qa.ubuntu.com/job/autopilot-ci/999/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/62/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/62/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/62/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/83/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/511/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/999/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-22:

FAILED: Continuous integration, rev:535
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1000/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/63/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/86/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/514/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1000/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Martin Pitt (pitti) wrote on 2015-01-23:

The packaging in debian/rules looks fine to me. However, it fails to build:

debian/rules override_dh_auto_build
make[1]: Entering directory '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806'
convert /«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.svg /«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf
convert: delegate failed `"rsvg-convert" -o "%o" "%i"' @ error/delegate.c/InvokeDelegate/1310.
convert: unable to open image `/tmp/magick-28976RCFje6T2VDtX': No such file or directory @ error/blob.c/OpenBlob/2709.
convert: unable to open file `/tmp/magick-28976RCFje6T2VDtX': No such file or directory @ error/constitute.c/ReadImage/540.
convert: no images defined `/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf' @ error/convert.c/ConvertImageCommand/3210.
make[1]: *** [/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf] Error 1
debian/rules:8: recipe for target '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806/docs/images/test_pyramid.pdf' failed
make[1]: Leaving directory '/«BUILDDIR»/autopilot-1.5.0+14.10.20140806'
make: *** [build] Error 2
debian/rules:14: recipe for target 'build' failed

Maybe that's still missing some build dep?

I can't quite see what changed in docs/man.rst, that seems to be some whitespace noise?

review: Needs Fixing

lp://staging/~canonical-platform-qa/autopilot/pdf-build updated on 2015-01-23

536. By Allan LeSage on 2015-01-23: Add librsvg2-bin build-dep.

Revision history for this message

Allan LeSage (allanlesage) wrote on 2015-01-23:

Mysterious missing dependency; this builds under pbuilder; we'll wait for Jenkins' approval--thanks for your notes pitti.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-26:

FAILED: Continuous integration, rev:536
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1004/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/67/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/67/artifact/work/output/*zip*/output.zip
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/67/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/96/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/560/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1004/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-26:

FAILED: Continuous integration, rev:536
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1005/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-amd64-ci/68/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-armhf-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/68
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-vivid-i386-ci/68/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/97
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid-autopilot/94
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/562
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/562/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1005/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Francis Ginther (fginther) wrote on 2015-01-26:

The jenkins node for the amd64 build failed, I've restarted a new ci run.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-01-26:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1007/rebuild

review: Approve (continuous-integration)

Revision history for this message

Nicholas Skaggs (nskaggs) wrote on 2015-02-17:

Unsure as to why there are newline changes in docs/man.rst. But otherwise, LGTM. Did you find texlive-fonts-recommended required? Is our font special?

Revision history for this message

platform-qa-bot (platform-qa-bot) wrote on 2016-01-19:

PASSED: Continuous integration, rev:536
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/11/
Executed test runs:
None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/11/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/11/rebuild

review: Approve (continuous-integration)

Unmerged revisions

536. By Allan LeSage on 2015-01-23: Add librsvg2-bin build-dep.
535. By Allan LeSage on 2015-01-22: debian/control whitespace fix.
534. By Allan LeSage on 2015-01-22: Clean up debian/rules comments :/ .
533. By Allan LeSage on 2015-01-22: Merge trunk.
532. By Allan LeSage on 2015-01-22: Makefile hackery to convert .svgs to .pdf, revert wildcard .svg change, add imagemagick build-dep.
531. By Allan LeSage on 2015-01-22: Revert whitespace change.
530. By Allan LeSage on 2015-01-22: Correct .svg extensions.
529. By Allan LeSage on 2015-01-22: Provide for pdf in debian-build.