Merge lp://staging/~canonical-platform-qa/autopilot/fixing_pid_search_1569079 into lp://staging/autopilot
Proposed by
Christopher Lee
| Status: | Merged |
|---|---|
| Approved by: | Christopher Lee |
| Approved revision: | 579 |
| Merged at revision: | 577 |
| Proposed branch: | lp://staging/~canonical-platform-qa/autopilot/fixing_pid_search_1569079 |
| Merge into: | lp://staging/autopilot |
| Diff against target: |
155 lines (+119/-1) 2 files modified
autopilot/introspection/_search.py (+42/-0) autopilot/tests/unit/test_introspection_search.py (+77/-1) |
| To merge this branch: | bzr merge lp://staging/~canonical-platform-qa/autopilot/fixing_pid_search_1569079 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot | continuous-integration | Approve | |
| Thomi Richards (community) | Approve | ||
| platform-qa-bot | continuous-integration | Approve | |
| Autopilot Hackers | Pending | ||
|
Review via email:
|
|||
Commit message
Add a final filter that ignores any children processes if the parent process matches and the supplied pid is the parents.
Description of the change
It's possible that a parent process spawns a child process that will match an attempt to get a proxy object for the parent.
Add a final filter that ignores any children processes if the parent process matches and the supplied pid is the parents.
To post a comment you must log in.
Revision history for this message
| Max Brustkern (nuclearbob) wrote | # |
Revision history for this message
| platform-qa-bot (platform-qa-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| platform-qa-bot (platform-qa-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| platform-qa-bot (platform-qa-bot) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Approve
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Seems reasonable to me, once we get a good test of it.