Autopilot

Merge lp://staging/~canonical-platform-qa/autopilot/fix-bug-1414781 into lp://staging/autopilot

  1. fix-bug-1414781
  2. Merge into trunk
Proposed by Sergio Cazzolato
Status: Needs review
Proposed branch: lp://staging/~canonical-platform-qa/autopilot/fix-bug-1414781
Merge into: lp://staging/autopilot
Diff against target: 266 lines (+54/-110)
4 files modified
autopilot/tests/__init__.py (+1/-57)
autopilot/tests/functional/test_input_stack.py (+10/-9)
autopilot/tests/unit/test_input.py (+12/-14)
autopilot/tests/unit/test_logging.py (+31/-30)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/autopilot/fix-bug-1414781
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Needs Fixing
Leo Arias (community) Needs Fixing
prod-platform-qa continuous-integration Pending
Sergio Cazzolato Pending
Review via email: mp+259276@code.staging.launchpad.net

Commit message

autopilot.tests.unit.LogHandlerTestCase replaced by fixtures.FakeLogger

Description of the change

Bux #1414781 fixed

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

Thanks Sergio. I left some comments in line.

Reply
Revision history for this message
Leo Arias (elopio) :
review: Needs Fixing
Reply
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) :
Reply
Revision history for this message
Leo Arias (elopio) :
Reply
lp://staging/~canonical-platform-qa/autopilot/fix-bug-1414781 updated
558. By Sergio Cazzolato

removing statements from with scope

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:557
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1072/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1072/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:557
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1073/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/4/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/3/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1073/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:558
http://jenkins.qa.ubuntu.com/job/autopilot-ci/1077/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-amd64-ci/8/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-armhf-ci/7/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-wily-i386-ci/8/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-ci/1077/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

PASSED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/9/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/9/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/9/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/122/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/359/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/357/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1835/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/122/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/131/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/391/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/389/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1879/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/131/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/140/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/419/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/419/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1916/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/140/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/149/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/444/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/444/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1945/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/149/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :

FAILED: Continuous integration, rev:558
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/158/
Executed test runs:
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-amd64-package/458/console
    FAILURE: https://platform-qa-jenkins.ubuntu.com/job/build-xenial-i386-package/458/console
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1963/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/autopilot-ci/158/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

558. By Sergio Cazzolato

removing statements from with scope

557. By Sergio Cazzolato

LogHandlerTestCase removed, now using the FakeLogger as was suggested in the bug

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches