Merge lp://staging/~canonical-platform-qa/auto-upgrade-testing-specifications/updating_profiles into lp://staging/auto-upgrade-testing-specifications

Proposed by Christopher Lee
Status: Merged
Approved by: Max Brustkern
Approved revision: 11
Merged at revision: 2
Proposed branch: lp://staging/~canonical-platform-qa/auto-upgrade-testing-specifications/updating_profiles
Merge into: lp://staging/auto-upgrade-testing-specifications
Diff against target: 601 lines (+460/-0)
21 files modified
cloudinit/default (+16/-0)
cloudinit/ubuntu-desktop (+20/-0)
examples/backends/backend-example-lxc.yaml (+16/-0)
examples/backends/backend-example-qemu.yaml (+15/-0)
examples/backends/backend-example-touch.yaml (+14/-0)
examples/specifications/example-test-specification.yaml (+32/-0)
profiles/trusty/ubuntu-trusty-xenial-basic-amd64_lxc.yaml (+15/-0)
profiles/trusty/ubuntu-trusty-xenial-basic-amd64_qemu.yaml (+16/-0)
profiles/trusty/ubuntu-trusty-xenial-basic-i386_lxc.yaml (+15/-0)
profiles/trusty/ubuntu-trusty-xenial-basic-i386_qemu.yaml (+16/-0)
profiles/trusty/ubuntu-trusty-xenial-desktop-amd64_lxc.yaml (+15/-0)
profiles/trusty/ubuntu-trusty-xenial-desktop-amd64_qemu.yaml (+18/-0)
profiles/trusty/ubuntu-trusty-xenial-desktop-i386_lxc.yaml (+15/-0)
profiles/trusty/ubuntu-trusty-xenial-desktop-i386_qemu.yaml (+18/-0)
profiles/wily/ubuntu-wily-xenial-basic-amd64_qemu.yaml (+16/-0)
profiles/wily/ubuntu-wily-xenial-basic-i386_qemu.yaml (+16/-0)
profiles/wily/ubuntu-wily-xenial-desktop-amd64_qemu.yaml (+18/-0)
profiles/wily/ubuntu-wily-xenial-desktop-i386_qemu.yaml (+18/-0)
tests/lts-desktop/post (+104/-0)
tests/lts-desktop/pre (+43/-0)
tests/null (+4/-0)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/auto-upgrade-testing-specifications/updating_profiles
Reviewer Review Type Date Requested Status
Max Brustkern (community) Approve
Review via email: mp+286575@code.staging.launchpad.net

Commit message

Update specifications to refer to tests scripts relative path. Update details in examples.

Description of the change

Update specifications to refer to tests scripts relative path. Update details in examples.

To post a comment you must log in.
8. By Christopher Lee

Actually upgrade the example touch specification.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

We'll also need the cloudinit directory for some of the desktop profiles to work. Also, diff comments. Most of them could be ignored until later, but it seems like a little cleanup when starting a new project isn't the worst idea. I can make a branch for that if you want.

Revision history for this message
Christopher Lee (veebers) wrote :

Sweet, thanks for the review. Have commented or fixed based on suggestions.

9. By Christopher Lee

Remove uneeded scripts

10. By Christopher Lee

Update testnames

Revision history for this message
Max Brustkern (nuclearbob) wrote :

The qemu desktop profiles will break if we don't add the cloudinit directory here. Other than that, I think we're good to go.

11. By Christopher Lee

Adding cloudinit directory.

Revision history for this message
Christopher Lee (veebers) wrote :

Thanks Max, I have added the missing cloudinit directory. I imagine I will need to remove it from the auto-upgrade-testing project.

Revision history for this message
Max Brustkern (nuclearbob) wrote :

Looks good! We can do that whenever, it'll be good to clean up the other tree but since we're pulling from this one it won't be any obstruction to deployment.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches