Merge lp://staging/~canonical-platform-qa/address-book-app/remove-teardown-ap-tests into lp://staging/address-book-app

Proposed by Christopher Lee
Status: Needs review
Proposed branch: lp://staging/~canonical-platform-qa/address-book-app/remove-teardown-ap-tests
Merge into: lp://staging/address-book-app
Diff against target: 68 lines (+27/-10)
1 file modified
tests/autopilot/address_book_app/tests/__init__.py (+27/-10)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/address-book-app/remove-teardown-ap-tests
Reviewer Review Type Date Requested Status
Federico Gimenez (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Vincent Ladeuil (community) Needs Information
Leo Arias (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+258829@code.staging.launchpad.net

Commit message

Test now uses addCleanup to re-start the OSK.

Description of the change

Test now uses addCleanup to re-start the OSK.
I had an issue where the OSK wasn't started after a test which caused the following tests to fail when they tried to stop an already stopped service.

To post a comment you must log in.
430. By Christopher Lee

User a fixture instead.

431. By Christopher Lee

Oops, forgot to re-raise

Revision history for this message
Leo Arias (elopio) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Vincent Ladeuil (vila) wrote :

See inline question.

review: Needs Information
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
432. By Christopher Lee

Actuall log error message from command call

Revision history for this message
Christopher Lee (veebers) wrote :

> See inline question.
Good point, now logging better details.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Federico Gimenez (fgimenez) wrote :

LGTM

review: Approve

Unmerged revisions

432. By Christopher Lee

Actuall log error message from command call

431. By Christopher Lee

Oops, forgot to re-raise

430. By Christopher Lee

User a fixture instead.

429. By Christopher Lee

Remove need for tearDown using addCleanup

428. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

427. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

426. By Launchpad Translations on behalf of phablet-team

Launchpad automatic translations update.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches