address-book-app

Merge lp://staging/~canonical-platform-qa/address-book-app/flake8-fixes into lp://staging/address-book-app

  1. flake8-fixes
  2. Merge into trunk
Proposed by Federico Gimenez
Status: Merged
Approved by: Renato Araujo Oliveira Filho
Approved revision: 423
Merged at revision: 427
Proposed branch: lp://staging/~canonical-platform-qa/address-book-app/flake8-fixes
Merge into: lp://staging/address-book-app
Diff against target: 300 lines (+73/-42)
8 files modified
tests/autopilot/address_book_app/__init__.py (+3/-3)
tests/autopilot/address_book_app/pages/_contact_editor.py (+4/-2)
tests/autopilot/address_book_app/pages/_sim_card_import_page.py (+4/-1)
tests/autopilot/address_book_app/tests/test_add_contact.py (+10/-9)
tests/autopilot/address_book_app/tests/test_custom_proxy_objects.py (+1/-0)
tests/autopilot/address_book_app/tests/test_edit_contact.py (+4/-2)
tests/autopilot/address_book_app/tests/test_multiple_pick_mode.py (+18/-10)
tests/autopilot/address_book_app/tests/test_single_pick_mode.py (+29/-15)
To merge this branch: bzr merge lp://staging/~canonical-platform-qa/address-book-app/flake8-fixes
Reviewer Review Type Date Requested Status
Renato Araujo Oliveira Filho (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Leo Arias (community) Approve
Review via email: mp+256684@code.staging.launchpad.net

Commit message

Flake8 fixes

Description of the change

Flake8 fixes

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:423
http://jenkins.qa.ubuntu.com/job/address-book-app-ci/795/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/address-book-app-vivid-i386-ci/98
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/2322
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/811/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/2037
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2320
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/2320/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19765
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/650/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/972
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/972/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/address-book-app-ci/795/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Renato Araujo Oliveira Filho (renatofilho) wrote :

looks good

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches