Merge lp://staging/~canonical-isd-hackers/wordpress-teams-integration/prevent-removing-bound-server-fix into lp://staging/wordpress-teams-integration
Proposed by
Szilveszter Farkas
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Stuart Metcalfe | ||||
| Approved revision: | 30 | ||||
| Merged at revision: | not available | ||||
| Proposed branch: | lp://staging/~canonical-isd-hackers/wordpress-teams-integration/prevent-removing-bound-server-fix | ||||
| Merge into: | lp://staging/wordpress-teams-integration | ||||
| Diff against target: |
76 lines (+37/-10) 1 file modified
openid-teams.php (+37/-10) |
||||
| To merge this branch: | bzr merge lp://staging/~canonical-isd-hackers/wordpress-teams-integration/prevent-removing-bound-server-fix | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stuart Metcalfe (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Do not allow deleting servers if one of the selected servers are bound to an existing role.
To post a comment you must log in.
Revision history for this message
| Stuart Metcalfe (stuartmetcalfe) wrote | # |
Revision history for this message
| Stuart Metcalfe (stuartmetcalfe) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Everything in rev. 27 looks good so far. We discussed removing the 'delete' checkbox from the servers form for each server already assigned to a team to avoid even giving the option to delete a server which the user shouldn't be able to delete. This looks possible, so will re-review when that's landed.