Merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/sso-preflight into lp://staging/canonical-identity-provider/release
Proposed by
David Owen
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | David Owen | ||||
| Approved revision: | no longer in the source branch. | ||||
| Merged at revision: | 135 | ||||
| Proposed branch: | lp://staging/~canonical-isd-hackers/canonical-identity-provider/sso-preflight | ||||
| Merge into: | lp://staging/canonical-identity-provider/release | ||||
| Diff against target: |
239 lines (+83/-56) 8 files modified
debian/control (+2/-0) identityprovider/auth.py (+9/-0) identityprovider/decorators.py (+15/-0) identityprovider/preflight.py (+42/-0) identityprovider/tests/test_views_preflight.py (+12/-11) identityprovider/urls.py (+0/-4) identityprovider/views/versions.py (+0/-39) setup.py (+3/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/sso-preflight | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ricardo Kirkner (community) | Approve | ||
| Łukasz Czyżykowski | Pending | ||
|
Review via email:
|
|||
Commit message
Added preflight, removed old +versions page
Description of the change
Be sure to grab the config changes at https:/
Brings Łukasz's django-preflight into SSO. Part of preflight includes a version check, which completely supersedes SSO's previous /+versions page.
I've added only one preflight check (DB connectivity). I have filed bugs for logging and OOPS checks, which will not be trivial.
To post a comment you must log in.
Revision history for this message
| David Owen (dsowen) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I rebased to pull in the new bootstrap changes, but I haven't been able to produce an environment that works since.