Canonical SSO provider

Merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/lp_apps_link into lp://staging/~canonical-isd-hackers/canonical-identity-provider/stable

  1. lp_apps_link
  2. Merge into stable
Proposed by David Owen
Status: Merged
Merged at revision: 44
Proposed branch: lp://staging/~canonical-isd-hackers/canonical-identity-provider/lp_apps_link
Merge into: lp://staging/~canonical-isd-hackers/canonical-identity-provider/stable
Diff against target: 91 lines (+36/-22)
2 files modified
identityprovider/tests/test_static.py (+31/-21)
identityprovider/urls.py (+5/-1)
To merge this branch: bzr merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/lp_apps_link
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+30147@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
David Owen (dsowen) wrote :

Links to /+applications don't appear anywhere in the Launchpad theme.

Revision history for this message
Anthony Lenton (elachuni) wrote :

Could you add a brief test for this? Check how the +faq and +description pages are tested to see that they're disabled with the LP theme for an example.

Revision history for this message
Ricardo Kirkner (ricardokirkner) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: