Canonical SSO provider

Merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug_579920 into lp://staging/canonical-identity-provider/release

bug_579920
Merge into trunk

Proposed by David Owen on 2010-05-22

Status:

Merged

Merged at revision:

Proposed branch:

lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug_579920

Merge into:

lp://staging/canonical-identity-provider/release

Diff against target:

41 lines (+21/-0)

2 files modified

identityprovider/forms.py (+1/-0)
identityprovider/tests/test_forms.py (+20/-0)

To merge this branch:

bzr merge lp://staging/~canonical-isd-hackers/canonical-identity-provider/bug_579920

Low

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Danny Tamez		2010-05-22	Pending
Review via email: mp+25812@code.staging.launchpad.net

This proposal supersedes a proposal from 2010-05-20.

Commit message

If the first password field has errors, errors regarding the second password field are suppressed (whether or not it matches the first field).

Includes unit tests.

Revision history for this message

Danny Tamez (zematynnad) wrote on 2010-05-20: Posted in a previous version of this proposal

First bug fix is looking good David. Please add a test and I'll approve. Also,even once approved please do not merge into trunk until we're out of code freeze.

review: Needs Fixing

Revision history for this message

David Owen (dsowen) wrote on 2010-05-21: Posted in a previous version of this proposal

On 05/20/2010 02:25 PM, Danny Tamez wrote:
> Review: Needs Fixing
>
> First bug fix is looking good David. Please add a test and I'll
> approve. Also,even once approved please do not merge into trunk until
> we're out of code freeze.

Okay, I might schedule that for after I wrap up my current bug (if not
sooner).

Thanks,
David

Revision history for this message

Danny Tamez (zematynnad) wrote on 2010-05-24: Posted in a previous version of this proposal

LGTM

review: Approve