Juju Charms Collection
jenkins-remote-slave package

Merge lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/configurable-lp-user into lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/trunk

  1. Trusty Tahr (14.04)
  2. configurable-lp-user
  3. Merge into trunk
Proposed by Francis Ginther
Status: Merged
Approved by: Francis Ginther
Approved revision: 25
Merged at revision: 20
Proposed branch: lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/configurable-lp-user
Merge into: lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/trunk
Diff against target: 124 lines (+44/-14)
6 files modified
config.yaml (+10/-0)
files/lp/authentication.conf (+1/-1)
files/lp/bazaar.conf (+2/-2)
hooks/install (+3/-3)
hooks/install.d/3000-ci-tools.sh (+4/-2)
hooks/install.d/4000-lp-keys.sh (+24/-6)
To merge this branch: bzr merge lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/configurable-lp-user
Reviewer Review Type Date Requested Status
Evan (community) Approve
Paul Larson Approve
Review via email: mp+243943@code.staging.launchpad.net

Commit message

Add lp_user and lp_email options to configure launchpad access and add some shell fixes to other parts of the charm.

Description of the change

Add lp_user and lp_email options to configure launchpad access and add some shell fixes to other parts of the charm.

To post a comment you must log in.
Revision history for this message
Evan (ev) wrote :

Small issues, otherwise looks good.

review: Needs Fixing
Revision history for this message
Francis Ginther (fginther) wrote :

Did some more testing and added some fixes to other parts of the charm. I can now deploy this standalone (previously I had made these changes as part of another work-in-progress and they were being tested along with other changes).

lp://staging/~canonical-ci-engineering/charms/trusty/jenkins-remote-slave/configurable-lp-user updated
25. By Francis Ginther

Revert change to make lp_user and lp_email checks a warning, I think I was wrong about the best way to do this.

Revision history for this message
Paul Larson (pwlars) wrote :

+1

review: Approve
Revision history for this message
Evan (ev) wrote :

Thanks for fixing all that. +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: