Merge lp://staging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander-fix-job-input into lp://staging/~canonical-ci-engineering/charms/precise/ubuntu-ci-services-itself/lander

LGTM. i'll work on rebasing my stuff on it.

i think this is still broke. I see something in master.xml:

# Convert to a format that can be passed to the child jobs
all_params=`cat all.json`
cat > child.json <<EOF
request_parameters=$all_params
EOF

That won't generate valid JSON. You also seem to call:

 request_parameters=$(echo $request_parameters | sed -e 's/^"//' -e 's/"$//')

two times - I don't see why?

Another thing that would make this easier: use CDATA in the command XML elements so we don't have all this " stuff

> i think this is still broke. I see something in master.xml:
>
> # Convert to a format that can be passed to the child jobs
> all_params=`cat all.json`
> cat > child.json <<EOF
> request_parameters=$all_params
> EOF
>
> That won't generate valid JSON. You also seem to call:
>
> request_parameters=$(echo $request_parameters | sed -e
> 's/^"//' -e 's/"$//')
>
> two times - I don't see why?
>
> Another thing that would make this easier: use CDATA in the command XML
> elements so we don't have all this " stuff

I agree the " stuff is hard to read.

Can't we have an external job instead to reduce the xml itself ?

That would make the whole stuff easier to test too.

I realize that the initial idea was to make it simpler to create jenkins
jobs but the downsides weigth seem to have increased enough to ruin that
initial ease.

Its awfully hard to review a jenkins job, but I think this looks like what I was wanting. I say merge it. Any issues I encounter can be fixed when I wire up the ppa-assigner and branch-source-builder.

Alrighty. Andy and Vincent,

I've wrapped the jenkins scripts in CDATA (I wish would have defaulted to this behavior, but oh well).

Also, the parameter passing from one child job to the next was broken because I foolishly developed my solution on my workstation which has a newer version of the jenkin's Parameterized Trigger Plugin and behaved differently. The parameters are now being passed by specifying the jenkins parameters via a json file. This now works for me, if it works for Andy I'll refine to trim the excess xml.

The specification of the datastore parameters is not required to make it all work and I'm looking for a better solution to specify these. If the parameters are missing, the lander_archive job will fail to work, but all this does is copy files to the data store. The lander workflow will continue to execute.