Purchase - Workflow and Organization

Merge lp://staging/~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi into lp://staging/~purchase-core-editors/purchase-wkfl/7.0

  1. 7.0-fix-missing-trigger-nbi
  2. Merge into 7.0
Proposed by Nicolas Bessi - Camptocamp
Status: Merged
Merged at revision: 27
Proposed branch: lp://staging/~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi
Merge into: lp://staging/~purchase-core-editors/purchase-wkfl/7.0
Diff against target: 23 lines (+7/-1)
1 file modified
framework_agreement/model/purchase.py (+7/-1)
To merge this branch: bzr merge lp://staging/~camptocamp/purchase-wkfl/7.0-fix-missing-trigger-nbi
Reviewer Review Type Date Requested Status
Leonardo Pistone code review Approve
Romain Deheele - Camptocamp (community) code review Approve
Purchase Core Editors Pending
Review via email: mp+206934@code.staging.launchpad.net

Description of the change

[FIX] merge trouble, missing trigger on purchase order line

To post a comment you must log in.
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

LGTM,

Regards,

Romain

review: Approve (code review)
Revision history for this message
Leonardo Pistone (lepistone) wrote :

LGTM.

Out of curiosity (I approve in any case) why do you actually need the trigger on the purchase line itself? in theory, purchase_id should not change.

review: Approve (code review)
Revision history for this message
Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote :

Leonardo,

In ngo-addons we often have code that create create PO first and in a second step the PO line, in this case trigger is not call.

Revision history for this message
Leonardo Pistone (lepistone) wrote :

thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches