Merge lp://staging/~camptocamp/product-extra-addons/extra-trunk-fix-1017960 into lp://staging/product-extra-addons

Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Sébastien BEAU - http://www.akretion.com
Approved revision: 48
Merged at revision: 61
Proposed branch: lp://staging/~camptocamp/product-extra-addons/extra-trunk-fix-1017960
Merge into: lp://staging/product-extra-addons
Diff against target: 129 lines (+36/-14)
2 files modified
product_images_olbs/product.py (+21/-7)
product_images_olbs/product_images.py (+15/-7)
To merge this branch: bzr merge lp://staging/~camptocamp/product-extra-addons/extra-trunk-fix-1017960
Reviewer Review Type Date Requested Status
Sébastien BEAU - http://www.akretion.com Pending
Guewen Baconnier @ Camptocamp Pending
Nicolas Bessi - Camptocamp Pending
Raphaël Valyi - http://www.akretion.com Pending
Review via email: mp+112316@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

Hi Alex.
I don't know if the best solution will be to not copy the image. Indeed when you duplicate a product, I am not sure that the customer want to keep the same image, so maybe it's simplier to not copy the image_ids and set it to false.

What do you think?

Thank you

Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

My current customer uses the duplicate product to handle the Sales period, and he wants the images to be copied... I can always overload the code for him but I'd rather have the images copied out of the box.

Revision history for this message
Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote :

Ok I finally agree.
I merge it in rev 61.

Thank you

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches