Merge lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe into lp://staging/ocb-addons

Proposed by Alexandre Fayolle - camptocamp
Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: no longer in the source branch.
Merged at revision: 10037
Proposed branch: lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe
Merge into: lp://staging/ocb-addons
Diff against target: 17 lines (+6/-1)
1 file modified
base_action_rule/base_action_rule.py (+6/-1)
To merge this branch: bzr merge lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix_action_rule_processing_lp1190592-afe
Reviewer Review Type Date Requested Status
Yann Papouin code review Approve
Leonardo Pistone code review Approve
Holger Brunn (Therp) code review Approve
Pedro Manuel Baeza code review Approve
Review via email: mp+209086@code.staging.launchpad.net

Description of the change

fix issue with action being erroneously repeated.

Port of https://code.launchpad.net/~camptocamp/openobject-addons/7.0-fix_action_rule_processing_lp1190592-afe/+merge/209077

Note that there is another MP on openobject-addons for this bug, which I personnaly find less clear (https://code.launchpad.net/~elbati/openobject-addons/7.0_fix_action_rule_processing/+merge/169191). If people think that the latter is better, just say so in the reviews and I'll update the ocb MP accordingly.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Indeed, a misuse of the one line sentences.

Regards.

review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

what we want is

if last_run and (last_run <= action_dt < now) or not last_run and (action_dt < now):

review: Approve (code review)
Revision history for this message
Leonardo Pistone (lepistone) :
review: Approve (code review)
Revision history for this message
Yann Papouin (yann-papouin) wrote :

This one is better to understand

review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.