OpenERP Community Backports (Addons)

Merge lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix-1231856-afe into lp://staging/ocb-addons

  1. ocb-7.0-fix-1231856-afe
  2. Merge into 7.0
Proposed by Alexandre Fayolle - camptocamp
Status: Work in progress
Proposed branch: lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix-1231856-afe
Merge into: lp://staging/ocb-addons
Diff against target: 11 lines (+1/-0)
1 file modified
stock/wizard/stock_invoice_onshipping.py (+1/-0)
To merge this branch: bzr merge lp://staging/~camptocamp/ocb-addons/ocb-7.0-fix-1231856-afe
Reviewer Review Type Date Requested Status
Alexandre Fayolle - camptocamp Needs Fixing
Stefan Rijnhart (Opener) Needs Information
Pedro Manuel Baeza code review, no test Approve
Review via email: mp+188013@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

this is used in production

Reply
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM

review: Approve (code review, no test)
Reply
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

I must admit that I am forever confused about whether to use the context date or the utc date, but I have the feeling that as this is a wizard run from the interface, you should use context_today. What do you think?

review: Needs Information
Reply
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote :

I'm rejecting this MP, because I think Amit is right and it is the other wizard which needs fixing.

As for which date is to be used I have absolutely no effing idea and I'm totally confused on that topic :-(

review: Disapprove
Reply
Revision history for this message
Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) :
review: Needs Fixing
Reply

Unmerged revisions

9540. By Alexandre Fayolle - camptocamp

[FIX] add a default value for invoice_date in stock.invoice.onshipping (lp:1231856)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.