Merge lp://staging/~camptocamp/ocb-addons/7.0-fix-1319109 into lp://staging/ocb-addons
Proposed by
Yannick Vaucher @ Camptocamp
| Status: | Merged |
|---|---|
| Approved by: | Leonardo Pistone |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 10207 |
| Proposed branch: | lp://staging/~camptocamp/ocb-addons/7.0-fix-1319109 |
| Merge into: | lp://staging/ocb-addons |
| Diff against target: |
131 lines (+25/-24) 1 file modified
report_webkit/webkit_report.py (+25/-24) |
| To merge this branch: | bzr merge lp://staging/~camptocamp/ocb-addons/7.0-fix-1319109 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Leonardo Pistone | Approve | ||
| Alexandre Fayolle - camptocamp | code review, no test | Approve | |
| Nicolas Bessi - Camptocamp (community) | no test, code review | Approve | |
| Florent | Pending | ||
|
Review via email:
|
|||
Description of the change
Transmit parser_instance using partial function for mako translation callback. This to remove parser_instance from attribute as it can cause race condition on cursors.
To post a comment you must log in.
Revision history for this message
| Nicolas Bessi - Camptocamp (nbessi-c2c-deactivatedaccount) wrote | # |
review:
Approve
(no test, code review)
Revision history for this message
| Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c) wrote | # |
review:
Approve
(code review, no test)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for providing the patch as disscussed.
Just a little
little indent
49 uid,
50 self.name2,
51 context=context)
else
LGTM